From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
Naohiro Aota <naohiro.aota@wdc.com>,
Johannes Thumshirn <jth@kernel.org>,
Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Jens Axboe <axboe@kernel.dk>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@kvack.org
Subject: Re: [PATCH] zonefs: Call zonefs_io_error() on any error from filemap_splice_read()
Date: Thu, 25 May 2023 16:21:49 +0100 [thread overview]
Message-ID: <ZG99DRyH461VAoUX@casper.infradead.org> (raw)
In-Reply-To: <3788353.1685003937@warthog.procyon.org.uk>
On Thu, May 25, 2023 at 09:38:57AM +0100, David Howells wrote:
>
> Call zonefs_io_error() after getting any error from filemap_splice_read()
> in zonefs_file_splice_read(), including non-fatal errors such as ENOMEM,
> EINTR and EAGAIN.
>
> Suggested-by: Damien Le Moal <dlemoal@kernel.org>
> Link: https://lore.kernel.org/r/5d327bed-b532-ad3b-a211-52ad0a3e276a@kernel.org/
This seems like a bizarre thing to do. Let's suppose you got an
-ENOMEM. blkdev_report_zones() is also likely to report -ENOMEM in
that case, which will cause a zonefs_err() to be called. Surely
that can't be the desired outcome from getting -ENOMEM!
next prev parent reply other threads:[~2023-05-25 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 8:38 [PATCH] zonefs: Call zonefs_io_error() on any error from filemap_splice_read() David Howells
2023-05-25 11:18 ` Johannes Thumshirn
2023-05-25 15:21 ` Matthew Wilcox [this message]
2023-05-25 23:04 ` Damien Le Moal
2023-05-25 23:46 ` Damien Le Moal
2023-05-26 14:07 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG99DRyH461VAoUX@casper.infradead.org \
--to=willy@infradead.org \
--cc=axboe@kernel.dk \
--cc=dhowells@redhat.com \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=jth@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@kvack.org \
--cc=linux-mm@kvack.org \
--cc=naohiro.aota@wdc.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).