From: Mike Rapoport <rppt@kernel.org>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memblock: Introduce memblock_reserve_node()
Date: Mon, 26 Jun 2023 09:21:42 +0300 [thread overview]
Message-ID: <ZJkudvnGz+Tt5Qml@kernel.org> (raw)
In-Reply-To: <4c361d62e0b77242fe4b8592c82c4d90@linux.dev>
On Sun, Jun 25, 2023 at 07:39:10AM +0000, Yajun Deng wrote:
> June 25, 2023 1:08 PM, "Mike Rapoport" <rppt@kernel.org> wrote:
>
> > On Sat, Jun 24, 2023 at 10:46:22AM +0800, Yajun Deng wrote:
> >
> >> It only returns address now in memblock_find_in_range_node(), we can add a
> >> parameter pointing to integer for node id of the range, which can be used
> >> to pass the node id to the new reserve region.
> >>
> >> Introduce memblock_reserve_node() so that the node id can be passed to
> >> the reserve region in memblock_alloc_range_nid().
> >>
> >> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> >
> > What problem does this patch solve?
> >
>
> If we set nid and flags in memblock_alloc_range_nid(), we may not need
> memblock_set_node() in memmap_init_reserved_pages().
When memblock_reserve() is called before NUMA setup, the node ids are still
unset in memblock.memory, so very early reservations will be missed and we
still have to update node ids in memblock.reserved later.
> I tested this patch and delete memblock_set_node() in memmap_init_reserved_pages().
> It works fine. I did not delete memblock_set_node() in this patch just in case.
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2023-06-26 6:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 2:46 [PATCH] memblock: Introduce memblock_reserve_node() Yajun Deng
2023-06-25 5:08 ` Mike Rapoport
2023-06-25 7:39 ` Yajun Deng
2023-06-26 6:21 ` Mike Rapoport [this message]
2023-06-27 0:13 ` Yajun Deng
2023-06-27 14:33 ` Mike Rapoport
2023-06-28 1:49 ` Yajun Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJkudvnGz+Tt5Qml@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).