From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] writeback: Account the number of pages written back
Date: Mon, 3 Jul 2023 03:13:15 +0100 [thread overview]
Message-ID: <ZKIuu6uQQJIQE640@casper.infradead.org> (raw)
In-Reply-To: <20230702130615.b72616d7f03b3ab4f6fc8dab@linux-foundation.org>
On Sun, Jul 02, 2023 at 01:06:15PM -0700, Andrew Morton wrote:
> On Wed, 28 Jun 2023 19:55:48 +0100 "Matthew Wilcox (Oracle)" <willy@infradead.org> wrote:
>
> > nr_to_write is a count of pages, so we need to decrease it by the number
> > of pages in the folio we just wrote, not by 1. Most callers specify
> > either LONG_MAX or 1, so are unaffected, but writeback_sb_inodes()
> > might end up writing 512x as many pages as it asked for.
>
> 512 is a big number, Should we backport this?
I'm really not sure. Maybe? I'm hoping one of the bots comes up with a
meaningful performance change as a result of this patch and we find out.
> > Fixes: 793917d997df ("mm/readahead: Add large folio readahead")
>
> I'm not seeing how a readahead change messed up writeback accounting?
That was the first patch which allowed large folios to be added to the
page cache. Until that point, this was latent. We could probably argue
for one of a dozen other commits around the same time.
next prev parent reply other threads:[~2023-07-03 2:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 18:55 [PATCH] writeback: Account the number of pages written back Matthew Wilcox (Oracle)
2023-06-28 21:53 ` Dave Chinner
2023-06-29 0:01 ` Matthew Wilcox
2023-06-29 1:02 ` Dave Chinner
2023-07-02 20:06 ` Andrew Morton
2023-07-03 2:13 ` Matthew Wilcox [this message]
2023-07-03 21:37 ` Dave Chinner
2023-07-04 18:03 ` Matthew Wilcox
2023-07-06 14:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKIuu6uQQJIQE640@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).