From: Peter Xu <peterx@redhat.com>
To: "Kasireddy, Vivek" <vivek.kasireddy@intel.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
David Hildenbrand <david@redhat.com>,
Hugh Dickins <hughd@google.com>, Jason Gunthorpe <jgg@nvidia.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Kim, Dongwon" <dongwon.kim@intel.com>,
"Chang, Junxiao" <junxiao.chang@intel.com>
Subject: Re: [PATCH v2 2/2] udmabuf: Add back support for mapping hugetlb pages (v2)
Date: Thu, 27 Jul 2023 16:54:03 -0400 [thread overview]
Message-ID: <ZMLZa2xF+tMg5t93@x1n> (raw)
In-Reply-To: <IA0PR11MB7185E6C4F0B9F4666A7C5CF7F839A@IA0PR11MB7185.namprd11.prod.outlook.com>
On Wed, Jul 19, 2023 at 05:42:54AM +0000, Kasireddy, Vivek wrote:
> > > + } else {
> > > + page =
> > shmem_read_mapping_page(mapping, pgoff + pgidx);
> >
> > It may not matter to your users, but the semantics for hugetlb and shmem
> > pages is different. hugetlb requires the pages exist in the page cache
> > while shmem will create/add pages to the cache if necessary.
> Ok; got it.
Would it be nice to do the same for both (perhaps always try to allocate)?
Thanks,
--
Peter Xu
prev parent reply other threads:[~2023-07-27 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 8:26 [PATCH v2 0/2] udmabuf: Add back support for mapping hugetlb pages (v2) Vivek Kasireddy
2023-07-18 8:26 ` [PATCH v2 1/2] udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap Vivek Kasireddy
2023-07-18 18:03 ` David Hildenbrand
2023-07-18 8:26 ` [PATCH v2 2/2] udmabuf: Add back support for mapping hugetlb pages (v2) Vivek Kasireddy
2023-07-18 18:05 ` David Hildenbrand
2023-07-18 23:44 ` Mike Kravetz
2023-07-19 5:42 ` Kasireddy, Vivek
2023-07-27 20:54 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMLZa2xF+tMg5t93@x1n \
--to=peterx@redhat.com \
--cc=david@redhat.com \
--cc=dongwon.kim@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hughd@google.com \
--cc=jgg@nvidia.com \
--cc=junxiao.chang@intel.com \
--cc=kraxel@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).