From: Michal Hocko <mhocko@suse.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Petr Mladek <pmladek@suse.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Luis Claudio R. Goncalves" <lgoncalv@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Boqun Feng <boqun.feng@gmail.com>, Ingo Molnar <mingo@redhat.com>,
John Ogness <john.ogness@linutronix.de>,
Mel Gorman <mgorman@techsingularity.net>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Waiman Long <longman@redhat.com>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2 1/2] seqlock: Do the lockdep annotation before locking in do_write_seqcount_begin_nested()
Date: Mon, 31 Jul 2023 16:25:16 +0200 [thread overview]
Message-ID: <ZMfETPzGfpPP7F79@dhcp22.suse.cz> (raw)
In-Reply-To: <649fa1a7-4efd-8cc7-92c7-ac7944adc283@I-love.SAKURA.ne.jp>
On Sat 29-07-23 20:05:43, Tetsuo Handa wrote:
> On 2023/07/29 14:31, Tetsuo Handa wrote:
> > On 2023/07/28 0:10, Sebastian Andrzej Siewior wrote:
> >> On 2023-06-28 21:14:16 [+0900], Tetsuo Handa wrote:
> >>>> Anyway, please do not do this change only because of printk().
> >>>> IMHO, the current ordering is more logical and the printk() problem
> >>>> should be solved another way.
> >>>
> >>> Then, since [PATCH 1/2] cannot be applied, [PATCH 2/2] is automatically
> >>> rejected.
> >>
> >> My understanding is that this patch gets applied and your objection will
> >> be noted.
> >
> > My preference is that zonelist_update_seq is not checked by !__GFP_DIRECT_RECLAIM
> > allocations, which is a low-hanging fruit towards GFP_LOCKLESS mentioned at
> > https://lkml.kernel.org/r/ZG3+l4qcCWTPtSMD@dhcp22.suse.cz and
> > https://lkml.kernel.org/r/ZJWWpGZMJIADQvRS@dhcp22.suse.cz .
> >
> > Maybe we can defer checking zonelist_update_seq till retry check like below,
> > for this is really an infrequent event.
> >
>
> An updated version with comments added.
Seriously, don't you see how hairy all this is? And for what? Nitpicking
something that doesn't seem to be a real problem in the first place?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2023-07-31 14:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 17:12 [PATCH v2 0/2] seqlock,mm: lockdep annotation + write_seqlock_irqsave() Sebastian Andrzej Siewior
2023-06-23 17:12 ` [PATCH v2 1/2] seqlock: Do the lockdep annotation before locking in do_write_seqcount_begin_nested() Sebastian Andrzej Siewior
2023-06-24 6:54 ` Tetsuo Handa
2023-06-26 8:12 ` Sebastian Andrzej Siewior
2023-06-26 9:25 ` Tetsuo Handa
2023-06-26 10:48 ` Peter Zijlstra
2023-06-26 11:26 ` Tetsuo Handa
2023-06-26 11:35 ` Michal Hocko
2023-06-26 12:27 ` Tetsuo Handa
2023-06-26 13:16 ` Michal Hocko
2023-06-26 12:46 ` Sebastian Andrzej Siewior
2023-06-26 13:13 ` Sebastian Andrzej Siewior
2023-06-26 14:44 ` Petr Mladek
2023-06-28 12:14 ` Tetsuo Handa
2023-07-27 15:10 ` Sebastian Andrzej Siewior
2023-07-29 5:31 ` Tetsuo Handa
2023-07-29 11:05 ` Tetsuo Handa
2023-07-31 14:25 ` Michal Hocko [this message]
2023-08-03 13:18 ` Tetsuo Handa
2023-08-03 14:49 ` Michal Hocko
2023-08-04 13:27 ` Tetsuo Handa
2023-08-07 8:20 ` Michal Hocko
2023-06-26 12:56 ` Mel Gorman
2023-06-23 17:12 ` [PATCH v2 2/2] mm/page_alloc: Use write_seqlock_irqsave() instead write_seqlock() + local_irq_save() Sebastian Andrzej Siewior
2023-06-23 18:17 ` Michal Hocko
2023-06-23 20:15 ` [PATCH v3 " Sebastian Andrzej Siewior
2023-06-26 7:56 ` David Hildenbrand
2023-06-26 13:14 ` Mel Gorman
2023-06-28 13:56 ` Michal Hocko
2023-06-25 2:27 ` [PATCH v2 0/2] seqlock,mm: lockdep annotation + write_seqlock_irqsave() Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMfETPzGfpPP7F79@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mgorman@techsingularity.net \
--cc=mingo@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).