From: Lincheng Yang <lincheng.yang@transsion.corp-partner.google.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: akpm@linux-foundation.org, rostedt@goodmis.org,
mhiramat@kernel.org, hughd@google.com, peterx@redhat.com,
mike.kravetz@oracle.com, jgg@ziepe.ca, surenb@google.com,
steven.price@arm.com, pasha.tatashin@soleen.com,
kirill.shutemov@linux.intel.com, yuanchu@google.com,
david@redhat.com, mathieu.desnoyers@efficios.com,
dhowells@redhat.com, shakeelb@google.com, pcc@google.com,
tytso@mit.edu, 42.hyeyoo@gmail.com, vbabka@suse.cz,
catalin.marinas@arm.com, lrh2000@pku.edu.cn,
ying.huang@intel.com, mhocko@suse.com, vishal.moola@gmail.com,
yosryahmed@google.com, findns94@gmail.com, neilb@suse.de,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
wanbin.wang@transsion.com, chunlei.zhuang@transsion.com,
jinsheng.zhao@transsion.com, jiajun.ling@transsion.com,
dongyun.liu@transsion.com,
Lincheng Yang <lincheng.yang@transsion.com>
Subject: Re: [RFC PATCH 4/5] mm: add page implyreclaim flag
Date: Tue, 10 Oct 2023 11:27:46 +0800 [thread overview]
Message-ID: <ZSTEssvguIBz5XWB@linchengyang-VB> (raw)
In-Reply-To: <ZSKNhZldD8P3l7hA@casper.infradead.org>
On Sun, Oct 08, 2023 at 12:07:49PM +0100, Matthew Wilcox wrote:
> On Sun, Oct 08, 2023 at 05:59:23PM +0800, Lincheng Yang wrote:
> > Add implyrecalim flag means that the page is reclaim from the user advise.
> > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> > index a2c83c0100aa..4a1278851d4b 100644
> > --- a/include/linux/page-flags.h
> > +++ b/include/linux/page-flags.h
> > @@ -138,6 +138,7 @@ enum pageflags {
> > #endif
> > PG_hot,
> > PG_cold,
> > + PG_implyreclaim,
> > __NR_PAGEFLAGS,
>
> Can you do all of this without adding three page flags? We're really
> tight on page flags. At a minimum, this is going to have to go behind
> an ifdef that depends on 64BIT, but it'd be better if we can derive
> hot/cold/implyreclaim from existing page flags. Look at the antics
Sounds good, we will try to do it with the exist page flags, if the exist page
flags does not achieve our goal, we will use an ifdef that depends on 64BIT.
> we go through for PG_young and PG_idle; if we had two page flags free,
> we'd spend them on removing the special cases there.
>
next prev parent reply other threads:[~2023-10-10 3:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-08 9:59 [RFC PATCH 0/5] hot page swap to zram, cold page swap to swapfile directly Lincheng Yang
2023-10-08 9:59 ` [RFC PATCH 1/5] mm/swap_slots: cleanup swap slot cache Lincheng Yang
2023-10-08 9:59 ` [RFC PATCH 2/5] mm: introduce hot and cold anon page flags Lincheng Yang
2023-10-08 9:59 ` [RFC PATCH 3/5] mm: add VMA hot flag Lincheng Yang
2023-10-08 9:59 ` [RFC PATCH 4/5] mm: add page implyreclaim flag Lincheng Yang
2023-10-08 11:07 ` Matthew Wilcox
2023-10-10 3:27 ` Lincheng Yang [this message]
2023-10-08 9:59 ` [RFC PATCH 5/5] mm/swapfile: add swapfile_write_enable interface Lincheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSTEssvguIBz5XWB@linchengyang-VB \
--to=lincheng.yang@transsion.corp-partner.google.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=chunlei.zhuang@transsion.com \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=dongyun.liu@transsion.com \
--cc=findns94@gmail.com \
--cc=hughd@google.com \
--cc=jgg@ziepe.ca \
--cc=jiajun.ling@transsion.com \
--cc=jinsheng.zhao@transsion.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=lincheng.yang@transsion.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lrh2000@pku.edu.cn \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=neilb@suse.de \
--cc=pasha.tatashin@soleen.com \
--cc=pcc@google.com \
--cc=peterx@redhat.com \
--cc=rostedt@goodmis.org \
--cc=shakeelb@google.com \
--cc=steven.price@arm.com \
--cc=surenb@google.com \
--cc=tytso@mit.edu \
--cc=vbabka@suse.cz \
--cc=vishal.moola@gmail.com \
--cc=wanbin.wang@transsion.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).