From: Roman Gushchin <roman.gushchin@linux.dev>
To: Shakeel Butt <shakeelb@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Muchun Song <muchun.song@linux.dev>,
Dennis Zhou <dennis@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: [PATCH v2 2/5] mm: kmem: add direct objcg pointer to task_struct
Date: Wed, 11 Oct 2023 11:05:49 -0700 [thread overview]
Message-ID: <ZSbj_SGkVj8wMY40@P9FQF9L96D.corp.robot.car> (raw)
In-Reply-To: <20231011180101.o2ha6awrupojcu6h@google.com>
On Wed, Oct 11, 2023 at 06:01:01PM +0000, Shakeel Butt wrote:
> On Mon, Oct 09, 2023 at 05:09:26PM -0700, Roman Gushchin wrote:
> [...]
> > +static void mem_cgroup_kmem_attach(struct cgroup_taskset *tset)
> > +{
> > + struct task_struct *task;
> > + struct cgroup_subsys_state *css;
> > +
> > + cgroup_taskset_for_each(task, css, tset) {
> > + /* atomically set the update bit */
> > + set_bit(0, (unsigned long *)¤t->objcg);
>
> task instead of current ??
Oh, right, of course, good catch!
Thanks!
next prev parent reply other threads:[~2023-10-11 18:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 0:09 [PATCH v2 0/5] mm: improve performance of accounted kernel memory allocations Roman Gushchin
2023-10-10 0:09 ` [PATCH v2 1/5] mm: kmem: optimize get_obj_cgroup_from_current() Roman Gushchin
2023-10-10 0:09 ` [PATCH v2 2/5] mm: kmem: add direct objcg pointer to task_struct Roman Gushchin
2023-10-11 18:01 ` Shakeel Butt
2023-10-11 18:05 ` Roman Gushchin [this message]
2023-10-10 0:09 ` [PATCH v2 3/5] mm: kmem: make memcg keep a reference to the original objcg Roman Gushchin
2023-10-11 19:51 ` Shakeel Butt
2023-10-10 0:09 ` [PATCH v2 4/5] mm: kmem: scoped objcg protection Roman Gushchin
2023-10-12 13:47 ` Shakeel Butt
2023-10-10 0:09 ` [PATCH v2 5/5] percpu: " Roman Gushchin
2023-10-12 13:48 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSbj_SGkVj8wMY40@P9FQF9L96D.corp.robot.car \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=dennis@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=naresh.kamboju@linaro.org \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).