From: Gregory Price <gregory.price@memverge.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Gregory Price <gourry.memverge@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-api@vger.kernel.org, corbet@lwn.net,
akpm@linux-foundation.org, honggyu.kim@sk.com, rakie.kim@sk.com,
hyeongtak.ji@sk.com, mhocko@kernel.org, vtavarespetr@micron.com,
jgroves@micron.com, ravis.opensrc@micron.com,
sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com,
seungjun.ha@samsung.com, hannes@cmpxchg.org,
dan.j.williams@intel.com
Subject: Re: [PATCH 2/3] mm/mempolicy: refactor a read-once mechanism into a function for re-use
Date: Wed, 17 Jan 2024 00:26:20 -0500 [thread overview]
Message-ID: <Zadk/BR4gFG07BVE@memverge.com> (raw)
In-Reply-To: <87h6jf1bfx.fsf@yhuang6-desk2.ccr.corp.intel.com>
On Mon, Jan 15, 2024 at 12:13:06PM +0800, Huang, Ying wrote:
> Gregory Price <gourry.memverge@gmail.com> writes:
>
> >
> > +static unsigned int read_once_policy_nodemask(struct mempolicy *pol,
> > + nodemask_t *mask)
>
> It may be more useful if we define this as memcpy_once(). That can be
> used not only for nodemask, but also other data structure.
>
Seemed better to do this is an entirely separate patch line to avoid
scope creep on reviews and such.
> > + barrier();
> > + __builtin_memcpy(mask, &pol->nodes, sizeof(nodemask_t));
>
> We don't use __builtin_memcpy() in kernel itself directly. Although it
> is used in kernel tools. So, I think it's better to use memcpy() here.
>
ack.
~Gregory
next prev parent reply other threads:[~2024-01-17 5:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 21:08 [PATCH 0/3] mm/mempolicy: weighted interleave mempolicy with sysfs extension Gregory Price
2024-01-12 21:08 ` [PATCH 2/3] mm/mempolicy: refactor a read-once mechanism into a function for re-use Gregory Price
2024-01-15 4:13 ` Huang, Ying
2024-01-17 5:26 ` Gregory Price [this message]
[not found] ` <20240112210834.8035-2-gregory.price@memverge.com>
2024-01-15 3:18 ` [PATCH 1/3] mm/mempolicy: implement the sysfs-based weighted_interleave interface Huang, Ying
2024-01-17 5:24 ` Gregory Price
2024-01-17 6:58 ` Huang, Ying
2024-01-17 17:46 ` Gregory Price
2024-01-18 4:37 ` Huang, Ying
[not found] ` <20240112210834.8035-4-gregory.price@memverge.com>
2024-01-15 5:47 ` [PATCH 3/3] mm/mempolicy: introduce MPOL_WEIGHTED_INTERLEAVE for weighted interleaving Huang, Ying
2024-01-17 5:34 ` Gregory Price
2024-01-18 1:28 ` Huang, Ying
2024-01-18 3:05 ` Huang, Ying
2024-01-18 4:06 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zadk/BR4gFG07BVE@memverge.com \
--to=gregory.price@memverge.com \
--cc=Hasan.Maruf@amd.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=emirakhur@micron.com \
--cc=gourry.memverge@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=honggyu.kim@sk.com \
--cc=hyeongtak.ji@sk.com \
--cc=jgroves@micron.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rakie.kim@sk.com \
--cc=ravis.opensrc@micron.com \
--cc=seungjun.ha@samsung.com \
--cc=sthanneeru@micron.com \
--cc=vtavarespetr@micron.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).