From: Vlastimil Babka <vbabka@suse.cz>
To: Nikita Ermakov <sh1r4s3@mail.si-head.nl>, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/msync: exit early when the flags is an MS_ASYNC and start < vm_start
Date: Tue, 20 Oct 2020 12:19:30 +0200 [thread overview]
Message-ID: <aaaaadff-977a-0e53-afe5-044889455fd6@suse.cz> (raw)
In-Reply-To: <20201012160911.6282-1-sh1r4s3@mail.si-head.nl>
On 10/12/20 6:09 PM, Nikita Ermakov wrote:
> Exit from the loop over the VMA in the case when the flags
> contain only an MS_ASYNC and start < vm_start. In this case msync()
> would return with -ENOMEM anyway so make it return early.
>
> Signed-off-by: Nikita Ermakov <sh1r4s3@mail.si-head.nl>
AFAICS it can still return -EBUSY if there's MS_INVALIDATE and a mlocked vma.
This is all subtle and I don't think we should risk breaking something for this
optimization.
> ---
> mm/msync.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mm/msync.c b/mm/msync.c
> index 69c6d2029531..ed20c3621d4c 100644
> --- a/mm/msync.c
> +++ b/mm/msync.c
> @@ -69,6 +69,8 @@ SYSCALL_DEFINE3(msync, unsigned long, start, size_t, len, int, flags)
> goto out_unlock;
> /* Here start < vma->vm_end. */
> if (start < vma->vm_start) {
> + if (flags == MS_ASYNC)
> + goto out_unlock;
> start = vma->vm_start;
> if (start >= end)
> goto out_unlock;
>
> base-commit: 6824a8a9b4861d7df7ee132a952bdf6f84a99cb8
>
next prev parent reply other threads:[~2020-10-20 10:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 16:09 [PATCH] mm/msync: exit early when the flags is an MS_ASYNC and start < vm_start Nikita Ermakov
2020-10-20 10:19 ` Vlastimil Babka [this message]
2020-10-20 14:38 ` Nikita
2020-10-20 15:03 ` Vlastimil Babka
2020-10-20 16:19 ` Nikita
2020-10-20 20:56 ` [PATCH v2] " Nikita Ermakov
2020-10-23 11:12 ` Vlastimil Babka
2020-10-25 9:29 ` [PATCH v3] " Nikita Ermakov
2020-10-25 9:38 ` [PATCH v2] " Nikita Ermakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaaaadff-977a-0e53-afe5-044889455fd6@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=sh1r4s3@mail.si-head.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).