From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f200.google.com (mail-wr0-f200.google.com [209.85.128.200]) by kanga.kvack.org (Postfix) with ESMTP id 4B26F6B0292 for ; Wed, 28 Jun 2017 07:10:52 -0400 (EDT) Received: by mail-wr0-f200.google.com with SMTP id z81so33238631wrc.2 for ; Wed, 28 Jun 2017 04:10:52 -0700 (PDT) Received: from Galois.linutronix.de (Galois.linutronix.de. [2a01:7a0:2:106d:700::1]) by mx.google.com with ESMTPS id u42si1514859wrc.363.2017.06.28.04.10.50 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 28 Jun 2017 04:10:50 -0700 (PDT) Date: Wed, 28 Jun 2017 13:10:14 +0200 (CEST) From: Thomas Gleixner Subject: Re: [PATCH] locking/atomics: don't alias ____ptr In-Reply-To: Message-ID: References: <85d51d3551b676ba1fc40e8fbddd2eadd056d8dd.1498140838.git.dvyukov@google.com> <20170628100246.7nsvhblgi3xjbc4m@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Dmitry Vyukov Cc: Sebastian Andrzej Siewior , Ingo Molnar , Mark Rutland , Peter Zijlstra , Will Deacon , "H. Peter Anvin" , Andrey Ryabinin , kasan-dev , "x86@kernel.org" , LKML , Andrew Morton , "linux-mm@kvack.org" , Linus Torvalds On Wed, 28 Jun 2017, Dmitry Vyukov wrote: > On Wed, Jun 28, 2017 at 12:02 PM, Sebastian Andrzej Siewior wrote: > > @@ -359,16 +359,16 @@ static __always_inline bool atomic64_add_negative(s64 i, atomic64_t *v) > > > > #define cmpxchg64(ptr, old, new) \ > > ({ \ > > - __typeof__(ptr) ____ptr = (ptr); \ > > - kasan_check_write(____ptr, sizeof(*____ptr)); \ > > - arch_cmpxchg64(____ptr, (old), (new)); \ > > + __typeof__(ptr) ____ptr64 = (ptr); \ > > + kasan_check_write(____ptr64, sizeof(*____ptr64));\ > > + arch_cmpxchg64(____ptr64, (old), (new)); \ > > }) > > > > #define cmpxchg64_local(ptr, old, new) \ > > ({ \ > > - __typeof__(ptr) ____ptr = (ptr); \ > > - kasan_check_write(____ptr, sizeof(*____ptr)); \ > > - arch_cmpxchg64_local(____ptr, (old), (new)); \ > > + __typeof__(ptr) ____ptr64 = (ptr); \ > > + kasan_check_write(____ptr64, sizeof(*____ptr64));\ > > + arch_cmpxchg64_local(____ptr64, (old), (new)); \ > > }) > > > > #define cmpxchg_double(p1, p2, o1, o2, n1, n2) \ > > > Doh! Thanks for fixing this. I think I've a similar crash in a > different place when I developed the patch. > The problem is that when we do: > > __typeof__(ptr) ____ptr = (ptr); \ > arch_cmpxchg64_local(____ptr, (old), (new)); \ > > We don't necessary pass value of our just declared ____ptr to > arch_cmpxchg64_local(). We just pass a symbolic identifier. So if > arch_cmpxchg64_local() declares own ____ptr and then tries to use what > we passed ("____ptr") it will actually refer to own variable declared > rather than to what we wanted to pass in. > > In my case I ended up with something like: > > __typeof__(foo) __ptr = __ptr; > > which compiler decided to turn into 0. > > Thank you, macros. > > We can add more underscores, but the problem can happen again. Should > we prefix current function/macro name to all local vars?.. Actually we can void that ___ptr dance completely. Thanks, tglx 8<-------------------- --- a/include/asm-generic/atomic-instrumented.h +++ b/include/asm-generic/atomic-instrumented.h @@ -359,37 +359,32 @@ static __always_inline bool atomic64_add #define cmpxchg(ptr, old, new) \ ({ \ - __typeof__(ptr) ___ptr = (ptr); \ - kasan_check_write(___ptr, sizeof(*___ptr)); \ + kasan_check_write((ptr), sizeof(*(ptr))); \ arch_cmpxchg((ptr), (old), (new)); \ }) #define sync_cmpxchg(ptr, old, new) \ ({ \ - __typeof__(ptr) ___ptr = (ptr); \ - kasan_check_write(___ptr, sizeof(*___ptr)); \ - arch_sync_cmpxchg(___ptr, (old), (new)); \ + kasan_check_write((ptr), sizeof(*(ptr))); \ + arch_sync_cmpxchg((ptr), (old), (new)); \ }) #define cmpxchg_local(ptr, old, new) \ ({ \ - __typeof__(ptr) ____ptr = (ptr); \ - kasan_check_write(____ptr, sizeof(*____ptr)); \ - arch_cmpxchg_local(____ptr, (old), (new)); \ + kasan_check_write((ptr), sizeof(*(ptr))); \ + arch_cmpxchg_local((ptr), (old), (new)); \ }) #define cmpxchg64(ptr, old, new) \ ({ \ - __typeof__(ptr) ____ptr = (ptr); \ - kasan_check_write(____ptr, sizeof(*____ptr)); \ - arch_cmpxchg64(____ptr, (old), (new)); \ + kasan_check_write((ptr), sizeof(*(ptr))); \ + arch_cmpxchg64((ptr), (old), (new)); \ }) #define cmpxchg64_local(ptr, old, new) \ ({ \ - __typeof__(ptr) ____ptr = (ptr); \ - kasan_check_write(____ptr, sizeof(*____ptr)); \ - arch_cmpxchg64_local(____ptr, (old), (new)); \ + kasan_check_write((ptr), sizeof(*(ptr))); \ + arch_cmpxchg64_local((ptr), (old), (new)); \ }) /* -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org