From: Hugh Dickins <hughd@google.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Song Liu <songliubraving@fb.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm,thp: stop leaking unreleased file pages
Date: Wed, 27 May 2020 14:28:10 -0700 (PDT) [thread overview]
Message-ID: <alpine.LSU.2.11.2005271402410.6459@eggly.anvils> (raw)
In-Reply-To: <20200526160140.GC850116@cmpxchg.org>
On Tue, 26 May 2020, Johannes Weiner wrote:
> On Sat, May 23, 2020 at 06:50:15PM -0700, Hugh Dickins wrote:
> > When collapse_file() calls try_to_release_page(), it has already
> > isolated the page: so if releasing buffers happens to fail (as it
> > sometimes does), remember to putback_lru_page(): otherwise that page is
> > left unreclaimable and unfreeable, and the file extent uncollapsible.
>
> Oof, I could imagine that was painful to debug (unless you already
> suspected file THP due to a targeted test or similar). Kudos.
Thanks, but I have to refuse both your admiration and sympathy:
mercifully, it was just something I noticed by source inspection
when working there.
I did then put in a debug count to see if it ever got hit in practice,
and checked after big multi-testing runs: it was sometimes hit, but
certainly not often, and I don't know what it was racing with when
it happened - would depend on filesystem anyway (ext4 in our case).
Saying "source inspection" reminds me: there is another funny in there,
but I don't think it matters very much in practice, and might need
rather a lot of testing to justify any particular patch: where
page_cache_sync_readahead() asks for PAGE_SIZE pages!
"end - index" seems a more reasonable number to me: but then we
might find that reading ahead into the next huge extent had actually
been a useful optimization (and those readahead functions impose
their own caps, so PAGE_SIZE shouldn't work out too outrageously).
Hugh
>
> > Signed-off-by: Hugh Dickins <hughd@google.com>
> > Fixes: 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem) FS")
> > Cc: stable@vger.kernel.org # v5.4+
>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2020-05-27 21:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 1:50 [PATCH] mm,thp: stop leaking unreleased file pages Hugh Dickins
2020-05-25 0:05 ` Song Liu
2020-05-25 4:32 ` Kirill A. Shutemov
2020-05-26 16:01 ` Johannes Weiner
2020-05-27 21:28 ` Hugh Dickins [this message]
2020-05-28 8:51 ` Naresh Kamboju
2020-06-03 21:51 ` Matthew Wilcox
2020-06-03 22:19 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.2005271402410.6459@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).