From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2634BC4361B for ; Mon, 7 Dec 2020 20:33:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 934952368A for ; Mon, 7 Dec 2020 20:33:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 934952368A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9E0768D0003; Mon, 7 Dec 2020 15:33:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 98EF68D0001; Mon, 7 Dec 2020 15:33:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87DED8D0003; Mon, 7 Dec 2020 15:33:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id 720658D0001 for ; Mon, 7 Dec 2020 15:33:39 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 46F103629 for ; Mon, 7 Dec 2020 20:33:38 +0000 (UTC) X-FDA: 77567636916.02.wing24_1109bca273e1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 20E3D10097AA3 for ; Mon, 7 Dec 2020 20:33:38 +0000 (UTC) X-HE-Tag: wing24_1109bca273e1 X-Filterd-Recvd-Size: 4811 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Mon, 7 Dec 2020 20:33:37 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id q25so1991009otn.10 for ; Mon, 07 Dec 2020 12:33:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=VF+dRBuajSL16Efm+Qk9iftapw2E7SOSirPhcnw+PnQ=; b=ZRA2+e52xlSYiJHPZTaBAxFXuVgSCguGt+17cXdyunFJAuKyaHC0N9M0+4wVV+JNu/ aS6Ru6m3Y+wnCnDvTaR0B9YOhtU4H+7LE/3LGO0G8PmR1IrdqhucfywKGLBMNQLyMXu/ XJSr+UlHYySaZWgshmFkJXhyvI//6ZYqsYHP2wgrjLmT1qlB1JlPb9O13tbr6L0bBWLe GRMCt7godtRnbrHZWJKC5DL6rW4nmuRO1x9OHwbZyq7CAqDi7cjSnTBdGjEjq1IFVhKo fbeRgmd7/Vs61w3QEF43+SBNzMP6YdnFO+5G59r4xPy9OUThCHiccAY3BNCrGBsllVky hvJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=VF+dRBuajSL16Efm+Qk9iftapw2E7SOSirPhcnw+PnQ=; b=p3l2TbCxTZ8yCsfondxUrCRZ879HnQI7v3TJpWYHW01sf0JnTPlj2nPLM9jzpYRMIt vsuSPddIQq7WXmVEhskrAFoeCrgJ9w6G2F01JZPUWg1E1R+u3z4q0/wlquFGx1EMKyZn 8i4CZxQ7cgESXtS8BwVi/BqZkB6GniNViwx2VxLd4Z32EtfytfTGFREgl9ubOdxB/OB5 5ZsZowrbSQvhq2sHmtBQHAzc/q4WYYZwhbrCHSNkcAgkvck24UbFNvtPCBxFieaQyAUK EEMPnay4L5o6hVSZZfdhQHO1iGJikL1gCz6c4NZrJMoha4+6P09RWxApiB0CLGVvrMte 61Vw== X-Gm-Message-State: AOAM533G25CPR6rsMi3wA5JOu891kGbwwBwh1u58l3VwmTwJCb/8rfca 4zb2vQifLyas3wSK8gC5JGreTg== X-Google-Smtp-Source: ABdhPJz9sBLcEczItc+x7GzdpccmdUkQq4OA2vpq4vUs629hT03tlx7plX6XLEideED+DfI8x+oGZg== X-Received: by 2002:a9d:4588:: with SMTP id x8mr14555151ote.169.1607373216384; Mon, 07 Dec 2020 12:33:36 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id n6sm2874818ota.73.2020.12.07.12.33.34 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 07 Dec 2020 12:33:35 -0800 (PST) Date: Mon, 7 Dec 2020 12:33:18 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Roman Gushchin cc: Michal Hocko , Muchun Song , Greg KH , rafael@kernel.org, Alexey Dobriyan , Andrew Morton , Johannes Weiner , Vladimir Davydov , Hugh Dickins , Will Deacon , Mike Rapoport , Thomas Gleixner , esyr@redhat.com, peterx@redhat.com, krisman@collabora.com, Suren Baghdasaryan , avagin@openvz.org, Marco Elver , Randy Dunlap , Joonsoo Kim , LKML , linux-fsdevel , Linux Memory Management List , Cgroups Subject: Re: [External] Re: [RESEND PATCH v2 00/12] Convert all vmstat counters to pages or bytes In-Reply-To: <20201207195141.GB2238414@carbon.dhcp.thefacebook.com> Message-ID: References: <20201206101451.14706-1-songmuchun@bytedance.com> <20201207130018.GJ25569@dhcp22.suse.cz> <20201207150254.GL25569@dhcp22.suse.cz> <20201207195141.GB2238414@carbon.dhcp.thefacebook.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 7 Dec 2020, Roman Gushchin wrote: > On Mon, Dec 07, 2020 at 04:02:54PM +0100, Michal Hocko wrote: > > > > As I've said the THP accounting change makes more sense to me because it > > allows future changes which are already undergoing so there is more > > merit in those. > > +1 > And this part is absolutely trivial. It does need to be recognized that, with these changes, every THP stats update overflows the per-cpu counter, resorting to atomic global updates. And I'd like to see that mentioned in the commit message. But this change is consistent with 4.7's 8f182270dfec ("mm/swap.c: flush lru pvecs on compound page arrival"): we accepted greater overhead for greater accuracy back then, so I think it's okay to do so for THP stats. Hugh