From: Joe Perches <joe@perches.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org
Subject: [PATCH] mm/page_alloc: Avoid KERN_CONT uses in warn_alloc
Date: Mon, 6 Nov 2017 10:02:56 -0800 [thread overview]
Message-ID: <b31236dfe3fc924054fd7842bde678e71d193638.1509991345.git.joe@perches.com> (raw)
KERN_CONT/pr_cont uses should be avoided where possible.
Use single pr_warn calls instead.
Signed-off-by: Joe Perches <joe@perches.com>
---
mm/page_alloc.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 536431bf0f0c..82e6d2c914ab 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3275,19 +3275,17 @@ void warn_alloc(gfp_t gfp_mask, nodemask_t *nodemask, const char *fmt, ...)
if ((gfp_mask & __GFP_NOWARN) || !__ratelimit(&nopage_rs))
return;
- pr_warn("%s: ", current->comm);
-
va_start(args, fmt);
vaf.fmt = fmt;
vaf.va = &args;
- pr_cont("%pV", &vaf);
- va_end(args);
-
- pr_cont(", mode:%#x(%pGg), nodemask=", gfp_mask, &gfp_mask);
if (nodemask)
- pr_cont("%*pbl\n", nodemask_pr_args(nodemask));
+ pr_warn("%s: %pV, mode:%#x(%pGg), nodemask=%*pbl\n",
+ current->comm, &vaf, gfp_mask, &gfp_mask,
+ nodemask_pr_args(nodemask));
else
- pr_cont("(null)\n");
+ pr_warn("%s: %pV, mode:%#x(%pGg), nodemask=(null)\n",
+ current->comm, &vaf, gfp_mask, &gfp_mask);
+ va_end(args);
cpuset_print_current_mems_allowed();
--
2.15.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2017-11-06 18:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 18:02 Joe Perches [this message]
2017-11-07 12:50 ` [PATCH] mm/page_alloc: Avoid KERN_CONT uses in warn_alloc Michal Hocko
2017-11-07 15:34 ` Joe Perches
2017-11-07 15:43 ` Michal Hocko
2017-11-07 16:03 ` Joe Perches
2017-11-09 10:05 ` Michal Hocko
2017-11-09 15:49 ` Joe Perches
2017-11-09 16:03 ` Michal Hocko
2017-11-09 16:27 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b31236dfe3fc924054fd7842bde678e71d193638.1509991345.git.joe@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).