From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA978EE3F2A for ; Tue, 26 Sep 2023 06:23:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A2AC8D0070; Tue, 26 Sep 2023 02:23:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 252AB8D0005; Tue, 26 Sep 2023 02:23:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 142248D0070; Tue, 26 Sep 2023 02:23:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EA2AF8D0005 for ; Tue, 26 Sep 2023 02:23:54 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8F87412103B for ; Tue, 26 Sep 2023 06:23:53 +0000 (UTC) X-FDA: 81277757946.14.9D41082 Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 707901C001A for ; Tue, 26 Sep 2023 06:23:48 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695709431; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+VZVxVXsCQtNv6c+71KYuB2jwj8YI5MtEHubiItC2iQ=; b=2tvwL+7kFTezmdlRkwsfCu7C19QBtcnnmc1IBlIyMZzYo0x1NvEf6a1PXf4rFJLj8VNKUA MHpLPf9IHkxwvSvvDjzJpbU2cA3311epKJco/URssmFeBJqAwQMaU43HG8fG5nna7zIsWl DX0mvadk2TEXwPO3FnBnlfTbpB1zWj8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695709431; a=rsa-sha256; cv=none; b=4z3D8C4ug8oHwbTi00CObv7cJNwI3vO/wDCwrM8RjxNN+g3NRowwSiR2ihs7kje1bn5OvO rYz71YHU/rmRyQctle4d3w4oDYT/kDO6NFKkvsgPih2tMZr+8ki97pEIk6COwDZrXUt1dC aaCtoJmVVTE8xb4imWNqIv+OF2w3bjM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R541e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=34;SR=0;TI=SMTPD_---0VsvlMsY_1695709421; Received: from 30.240.112.49(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0VsvlMsY_1695709421) by smtp.aliyun-inc.com; Tue, 26 Sep 2023 14:23:44 +0800 Message-ID: Date: Tue, 26 Sep 2023 14:23:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [RESEND PATCH v8 1/2] ACPI: APEI: set memory failure flags as MF_ACTION_REQUIRED on synchronous events Content-Language: en-US To: Jarkko Sakkinen , rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, gregkh@linuxfoundation.org, will@kernel.org Cc: linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, stable@vger.kernel.org, x86@kernel.org, justin.he@arm.com, ardb@kernel.org, ying.huang@intel.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20230919022127.69732-2-xueshuai@linux.alibaba.com> From: Shuai Xue In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 707901C001A X-Rspam-User: X-Stat-Signature: k155n46xs4nhbzp7jyif9tk38gqmroz7 X-Rspamd-Server: rspam03 X-HE-Tag: 1695709428-692187 X-HE-Meta: U2FsdGVkX190zrPkff+jiQJE4FIlWVUbD0YQC/1NeVNMGv7Ai/7THSY7SSXFQ9l8DtqJZkpRGS11VJDwJYf8bKkDT7mlV7yeZutcturhGa1nEfYeP7EsE3NxVgPayp1TSa+hlrCmbeWNRB022djYVx07rMsswHJE7QUciHhMrDnaWx+61op6K4EECaWHX5p6hW95zYF+wllBjPR8EtI2LJcpbrUOf7fA1o5BvCYMf9BZUfTtrNEfQ9HATzaNeGypPRyKmO3vWnNh+rdAf+gNXy/JPiP9gcEqz0dK9fJoSxtLHaucRznx6nLWducY07nRW7f0NVBenGRt5fl4ucc/6G84BmZVPMFFWxfhzmAAVT3pyl2mabE+Rh44ii3B115rpRKa/SApxH+eZUWJITD33I34KCemoK0qej+FqDABeqDBneGtkYLnL7mwMVpzjh3O1LMAD2u57ZGz/vP98BVJBu9L4MReSb+N+O77z5co+6b/InIgyLmlqpmvNxGNmobg3/ltcxUNbfyqF64u0xnVX9v7bpJJFHfXUMcjEKi4CVSM/0AuGNwsRL3ZxnCAj6W20791H8FN2xwckq8irF+193kKPCys8vx0tbDFuDM0pTCNG+EnVTed3UsltRAXMZEIRczNCEoHZN28yol6EiCHTkC5R9iTkGVwISa99mF3xd1ney0YAMz+OnoVykYjmlziKHDKXDmXAX09ly8lRkL3FBQtq8+45M82QAtEeQTWqXvfZfUb3WcHC2Zv2oF2PVsjKmYz8VhIQA/8xDTNWDqbf71pX22U4JqGjLE014/mr08NT3qHCQky5ClwI+fKdWInbbv9F5TNgCW6SdMbXJyY1tV1UdES8gXVPgzFhJFS38xl9UBsA4zr8UVuEe+8erF/TtfbYjpuge9GLsUOxcJrleNBrbobJ/X9yxs6viNcrAkvRs7dDM8waADlZMypoIAlVFfrmN2fb/41zD/I6GV 0LQWKd+Y LjHwu8gzWtakCS8X5J2yXVzoNM1nA/HhKxRSya30xGs5r5f8oyeFS+KTxoVb9oJ9U9iwnh1afpSfgD/LNwq2wpJ2ClxFLwabTaps1s/lqDRPcBy1c8N2hYKwIygvXEeW7A/0S5bVpMFKy7J5D1Ji+5gJasEG67P4B74yV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/9/25 22:43, Jarkko Sakkinen wrote: > On Tue Sep 19, 2023 at 5:21 AM EEST, Shuai Xue wrote: >> There are two major types of uncorrected recoverable (UCR) errors : >> >> - Action Required (AR): The error is detected and the processor already >> consumes the memory. OS requires to take action (for example, offline >> failure page/kill failure thread) to recover this uncorrectable error. >> >> - Action Optional (AO): The error is detected out of processor execution >> context. Some data in the memory are corrupted. But the data have not >> been consumed. OS is optional to take action to recover this >> uncorrectable error. >> >> The essential difference between AR and AO errors is that AR is a >> synchronous event, while AO is an asynchronous event. The hardware will >> signal a synchronous exception (Machine Check Exception on X86 and >> Synchronous External Abort on Arm64) when an error is detected and the >> memory access has been architecturally executed. >> >> When APEI firmware first is enabled, a platform may describe one error >> source for the handling of synchronous errors (e.g. MCE or SEA notification >> ), or for handling asynchronous errors (e.g. SCI or External Interrupt >> notification). In other words, we can distinguish synchronous errors by >> APEI notification. For AR errors, kernel will kill current process >> accessing the poisoned page by sending SIGBUS with BUS_MCEERR_AR. In >> addition, for AO errors, kernel will notify the process who owns the >> poisoned page by sending SIGBUS with BUS_MCEERR_AO in early kill mode. >> However, the GHES driver always sets mf_flags to 0 so that all UCR errors >> are handled as AO errors in memory failure. >> >> To this end, set memory failure flags as MF_ACTION_REQUIRED on synchronous >> events. >> >> Fixes: ba61ca4aab47 ("ACPI, APEI, GHES: Add hardware memory error recovery support")' >> Signed-off-by: Shuai Xue >> Tested-by: Ma Wupeng >> Reviewed-by: Kefeng Wang >> Reviewed-by: Xiaofei Tan >> Reviewed-by: Baolin Wang >> --- >> drivers/acpi/apei/ghes.c | 29 +++++++++++++++++++++++------ >> 1 file changed, 23 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c >> index ef59d6ea16da..88178aa6222d 100644 >> --- a/drivers/acpi/apei/ghes.c >> +++ b/drivers/acpi/apei/ghes.c >> @@ -101,6 +101,20 @@ static inline bool is_hest_type_generic_v2(struct ghes *ghes) >> return ghes->generic->header.type == ACPI_HEST_TYPE_GENERIC_ERROR_V2; >> } >> >> +/* >> + * A platform may describe one error source for the handling of synchronous >> + * errors (e.g. MCE or SEA), or for handling asynchronous errors (e.g. SCI >> + * or External Interrupt). On x86, the HEST notifications are always >> + * asynchronous, so only SEA on ARM is delivered as a synchronous >> + * notification. >> + */ >> +static inline bool is_hest_sync_notify(struct ghes *ghes) >> +{ >> + u8 notify_type = ghes->generic->notify.type; >> + >> + return notify_type == ACPI_HEST_NOTIFY_SEA; >> +} >> + >> /* >> * This driver isn't really modular, however for the time being, >> * continuing to use module_param is the easiest way to remain >> @@ -475,7 +489,7 @@ static bool ghes_do_memory_failure(u64 physical_addr, int flags) >> } >> >> static bool ghes_handle_memory_failure(struct acpi_hest_generic_data *gdata, >> - int sev) >> + int sev, bool sync) >> { >> int flags = -1; >> int sec_sev = ghes_severity(gdata->error_severity); >> @@ -489,7 +503,7 @@ static bool ghes_handle_memory_failure(struct acpi_hest_generic_data *gdata, >> (gdata->flags & CPER_SEC_ERROR_THRESHOLD_EXCEEDED)) >> flags = MF_SOFT_OFFLINE; >> if (sev == GHES_SEV_RECOVERABLE && sec_sev == GHES_SEV_RECOVERABLE) >> - flags = 0; >> + flags = sync ? MF_ACTION_REQUIRED : 0; > > Not my territory but this branching looks a bit weird to my > eyes so just in case putting a comment. > > What *if* the previous condition sets MF_SOFT_OFFLINE and > this condition overwrites the value? > > I know that earlier it could have been overwritten by zero. > > Neither the function comment has any explanation why it is > ok overwrite like this. > > Or if these cannot happen simultaenously why there is not > immediate return after settting MF_SOFT_OFFLINE? > > For someone like me the functions logic is tediously hard > to understand tbh. > > BR, Jarkko Hi, Jarkko, I hope the original source code can help to understand: /* iff following two events can be handled properly by now */ if (sec_sev == GHES_SEV_CORRECTED && (gdata->flags & CPER_SEC_ERROR_THRESHOLD_EXCEEDED)) flags = MF_SOFT_OFFLINE; if (sev == GHES_SEV_RECOVERABLE && sec_sev == GHES_SEV_RECOVERABLE) flags = 0; if (flags != -1) return ghes_do_memory_failure(mem_err->physical_addr, flags); The sec_sev of gdata is either GHES_SEV_CORRECTED or GHES_SEV_RECOVERABLE. So the two if-conditions are independent of each other and these cannot happen simultaneously. ghes_do_memory_failure() then handle the two events with a proper seted flags. Thanks. Best Regards, Shuai