From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E632C54F70 for ; Sun, 19 Apr 2020 22:55:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4B29A21841 for ; Sun, 19 Apr 2020 22:55:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B29A21841 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CD6DC8E0005; Sun, 19 Apr 2020 18:55:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C87268E0003; Sun, 19 Apr 2020 18:55:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9D888E0005; Sun, 19 Apr 2020 18:55:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id 9E8348E0003 for ; Sun, 19 Apr 2020 18:55:19 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 511EC180ACF9A for ; Sun, 19 Apr 2020 22:55:19 +0000 (UTC) X-FDA: 76726112358.01.queen87_85bc7608b8e19 X-HE-Tag: queen87_85bc7608b8e19 X-Filterd-Recvd-Size: 3409 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Sun, 19 Apr 2020 22:55:18 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id 145so1756139pfw.13 for ; Sun, 19 Apr 2020 15:55:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=B2msURkv1HA8pgGW6DbM9XBVc7YNXdLDiKpjaDG1YVk=; b=HXJ9Jcph/I1oQD9pl+T5pOIly1XGp+4nLvUBUJdLXrTdRJePT27jfUYvgqkqRFmOFX 7vBIY6l/ELluEYmDHIdIbQIDQ+yjPSv/ZVqvaWEMHnbKRseENXEIZ6IBt6uhWw7zC8a7 0JA+kDtgd0xNor0uyxk1uEctetDBuuVobszyvgUdi8esvUV25OcMcqz0VK4rW7Ue4Dci rlfXo1zenKJZKFztSaoTA3P5PoFzIdLrJyOKNpRr+oaFr+HdEBBYcmM9NiW0ycQtY51O f+cX4puppN0wPajfEaLBH502DF9tr9xuJXtuzf8a5zc5jnUW66AesJSGHS8KRAJ7CITv B9XQ== X-Gm-Message-State: AGi0PuYm0z0ERcTLiOD5favmLh4U3z/Rz79NQwy0pqSloAqBQnOoDEzj e8jY1fnYPCcrZ/xEvekGM1c= X-Google-Smtp-Source: APiQypJqULytJjZ0dNx4CNr/3fDiqkbJiEvNC2PKjACY87YZXhStXzwaxas2+Bodjrg58qN8tfS4HA== X-Received: by 2002:a63:1d4:: with SMTP id 203mr13204249pgb.74.1587336918151; Sun, 19 Apr 2020 15:55:18 -0700 (PDT) Received: from [100.124.11.78] ([104.129.198.64]) by smtp.gmail.com with ESMTPSA id o1sm2276514pjs.39.2020.04.19.15.55.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Apr 2020 15:55:17 -0700 (PDT) Subject: Re: [PATCH v2 07/10] blktrace: move debugfs file creation to its own function To: Luis Chamberlain , axboe@kernel.dk, viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org, rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org Cc: mhocko@suse.com, yukuai3@huawei.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20200419194529.4872-1-mcgrof@kernel.org> <20200419194529.4872-8-mcgrof@kernel.org> From: Bart Van Assche Message-ID: Date: Sun, 19 Apr 2020 15:55:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200419194529.4872-8-mcgrof@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/19/20 12:45 PM, Luis Chamberlain wrote: > +static int blk_trace_create_debugfs_files(struct blk_user_trace_setup *buts, > + struct dentry *dir, > + struct blk_trace *bt) > +{ > + int ret = -EIO; > + > + bt->dropped_file = debugfs_create_file("dropped", 0444, dir, bt, > + &blk_dropped_fops); > + > + bt->msg_file = debugfs_create_file("msg", 0222, dir, bt, &blk_msg_fops); > + > + bt->rchan = relay_open("trace", dir, buts->buf_size, > + buts->buf_nr, &blk_relay_callbacks, bt); > + if (!bt->rchan) > + return ret; > + > + return 0; > +} How about adding IS_ERR() checks for the debugfs_create_file() return values? Thanks, Bart.