From: osalvador@suse.de
To: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>
Cc: akpm@linux-foundation.org, Michal Hocko <MHocko@suse.com>,
linux-mm@kvack.org, mike.kravetz@oracle.com, david@redhat.com,
aneesh.kumar@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
Oscar Salvador <OSalvador@suse.com>
Subject: Re: [PATCH v4 12/15] mm,hwpoison: Rework soft offline for in-use pages
Date: Mon, 20 Jul 2020 10:27:10 +0200 [thread overview]
Message-ID: <c19693eb3600832976f44ffa746a263a@suse.de> (raw)
In-Reply-To: <f7387d64d0024d15a1bc821a8e19b8f0@DB7PR04MB5180.eurprd04.prod.outlook.com>
On 2020-07-17 08:55, HORIGUCHI NAOYA wrote:
> I ran Quan Cai's test program (https://github.com/cailca/linux-mm) on a
> small (4GB memory) VM, and weiredly found that (1) the target hugepages
> are not always dissolved and (2) dissovled hugetpages are still counted
> in "HugePages_Total:". See below:
>
> $ ./random 1
> - start: migrate_huge_offline
> - use NUMA nodes 0,1.
> - mmap and free 8388608 bytes hugepages on node 0
> - mmap and free 8388608 bytes hugepages on node 1
> madvise: Cannot allocate memory
>
> $ cat /proc/meminfo
> MemTotal: 4026772 kB
> MemFree: 976300 kB
> MemAvailable: 892840 kB
> Buffers: 20936 kB
> Cached: 99768 kB
> SwapCached: 5904 kB
> Active: 84332 kB
> Inactive: 116328 kB
> Active(anon): 27944 kB
> Inactive(anon): 68524 kB
> Active(file): 56388 kB
> Inactive(file): 47804 kB
> Unevictable: 7532 kB
> Mlocked: 0 kB
> SwapTotal: 2621436 kB
> SwapFree: 2609844 kB
> Dirty: 56 kB
> Writeback: 0 kB
> AnonPages: 81764 kB
> Mapped: 54348 kB
> Shmem: 8948 kB
> KReclaimable: 22744 kB
> Slab: 52056 kB
> SReclaimable: 22744 kB
> SUnreclaim: 29312 kB
> KernelStack: 3888 kB
> PageTables: 2804 kB
> NFS_Unstable: 0 kB
> Bounce: 0 kB
> WritebackTmp: 0 kB
> CommitLimit: 3260612 kB
> Committed_AS: 828196 kB
> VmallocTotal: 34359738367 kB
> VmallocUsed: 19260 kB
> VmallocChunk: 0 kB
> Percpu: 5120 kB
> HardwareCorrupted: 5368 kB
> AnonHugePages: 18432 kB
> ShmemHugePages: 0 kB
> ShmemPmdMapped: 0 kB
> FileHugePages: 0 kB
> FilePmdMapped: 0 kB
> CmaTotal: 0 kB
> CmaFree: 0 kB
> HugePages_Total: 1342 // still counted as hugetlb pages.
> HugePages_Free: 0 // all hugepage are still allocated
> (or leaked?)
> HugePages_Rsvd: 0
> HugePages_Surp: 762 // some are counted in surplus.
> Hugepagesize: 2048 kB
> Hugetlb: 2748416 kB
> DirectMap4k: 112480 kB
> DirectMap2M: 4081664 kB
>
>
> $ page-types -b hwpoison
> flags page-count MB symbolic-flags
> long-symbolic-flags
> 0x0000000000080008 421 1
> ___U_______________X_______________________ uptodate,hwpoison
> 0x00000000000a8018 1 0
> ___UD__________H_G_X_______________________
> uptodate,dirty,compound_head,huge,hwpoison
> 0x00000000000a801c 920 3
> __RUD__________H_G_X_______________________
> referenced,uptodate,dirty,compound_head,huge,hwpoison
> total 1342 5
>
> This means that some hugepages are dissolved, but the others not,
> maybe which is not desirable.
> I'll dig this more later but just let me share at first.
>
> A few minor comment below ...
Uhm, weird.
I will be taking a look today.
Thanks
next prev parent reply other threads:[~2020-07-20 8:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 12:37 [PATCH v4 00/15] Hwpoison soft-offline rework Oscar Salvador
2020-07-16 12:37 ` [PATCH v4 01/15] mm,hwpoison: cleanup unused PageHuge() check Oscar Salvador
2020-07-16 12:37 ` [PATCH v4 02/15] mm, hwpoison: remove recalculating hpage Oscar Salvador
2020-07-16 12:37 ` [PATCH v4 03/15] mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED Oscar Salvador
2020-07-16 23:15 ` Mike Kravetz
2020-07-16 12:37 ` [PATCH v4 04/15] mm,madvise: Refactor madvise_inject_error Oscar Salvador
2020-07-16 12:37 ` [PATCH v4 05/15] mm,hwpoison-inject: don't pin for hwpoison_filter Oscar Salvador
2020-07-16 12:38 ` [PATCH v4 06/15] mm,hwpoison: Un-export get_hwpoison_page and make it static Oscar Salvador
2020-07-16 12:38 ` [PATCH v4 07/15] mm,hwpoison: Kill put_hwpoison_page Oscar Salvador
2020-07-16 12:38 ` [PATCH v4 08/15] mm,hwpoison: remove MF_COUNT_INCREASED Oscar Salvador
2020-07-16 12:38 ` [PATCH v4 09/15] mm,hwpoison: remove flag argument from soft offline functions Oscar Salvador
2020-07-16 12:38 ` [PATCH v4 10/15] mm,hwpoison: Unify THP handling for hard and soft offline Oscar Salvador
2020-07-16 12:38 ` [PATCH v4 11/15] mm,hwpoison: Rework soft offline for free pages Oscar Salvador
2020-07-16 12:38 ` [PATCH v4 12/15] mm,hwpoison: Rework soft offline for in-use pages Oscar Salvador
2020-07-17 6:55 ` HORIGUCHI NAOYA(堀口 直也)
[not found] ` <f7387d64d0024d15a1bc821a8e19b8f0@DB7PR04MB5180.eurprd04.prod.outlook.com>
2020-07-20 8:27 ` osalvador [this message]
2020-07-22 8:08 ` osalvador
2020-07-23 10:19 ` Oscar Salvador
2020-07-16 12:38 ` [PATCH v4 13/15] mm,hwpoison: Refactor soft_offline_huge_page and __soft_offline_page Oscar Salvador
2020-07-16 12:38 ` [PATCH v4 14/15] mm,hwpoison: Return 0 if the page is already poisoned in soft-offline Oscar Salvador
2020-07-16 12:38 ` [PATCH v4 15/15] mm,hwpoison: introduce MF_MSG_UNSPLIT_THP Oscar Salvador
2020-07-16 12:38 ` [PATCH] x86/speculation: Add basic IBPB (Indirect Branch Prediction Barrier) support Oscar Salvador
2020-07-16 12:43 ` osalvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c19693eb3600832976f44ffa746a263a@suse.de \
--to=osalvador@suse.de \
--cc=MHocko@suse.com \
--cc=OSalvador@suse.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).