From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE
Date: Thu, 1 Nov 2018 13:48:17 +0300 [thread overview]
Message-ID: <cd2a55be-17f1-5da9-1154-8e291fe958cd@yandex-team.ru> (raw)
In-Reply-To: <20181101102405.GE23921@dhcp22.suse.cz>
On 01.11.2018 13:24, Michal Hocko wrote:
> On Thu 01-11-18 13:09:16, Konstantin Khlebnikov wrote:
>> Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc.
>
> I would go on and say that allocations with sizes too large can actually
> trigger a warning (once you have posted in the previous version outside
> of the changelog area) because that might be interesting to people -
> there are deployments to panic on warning and then a warning is much
> more important.
It seems that warning isn't completely valid.
__alloc_pages_slowpath() handles this more gracefully:
/*
* In the slowpath, we sanity check order to avoid ever trying to
* reclaim >= MAX_ORDER areas which will never succeed. Callers may
* be using allocators in order of preference for an area that is
* too large.
*/
if (order >= MAX_ORDER) {
WARN_ON_ONCE(!(gfp_mask & __GFP_NOWARN));
return NULL;
}
Fast path is ready for order >= MAX_ORDER
Problem is in node_reclaim() which is called earlier than __alloc_pages_slowpath()
from surprising place - get_page_from_freelist()
Probably node_reclaim() simply needs something like this:
if (order >= MAX_ORDER)
return NODE_RECLAIM_NOSCAN;
>
>> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
>
> Thanks!
>
>> ---
>> mm/util.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/mm/util.c b/mm/util.c
>> index 8bf08b5b5760..f5f04fa22814 100644
>> --- a/mm/util.c
>> +++ b/mm/util.c
>> @@ -392,6 +392,9 @@ void *kvmalloc_node(size_t size, gfp_t flags, int node)
>> gfp_t kmalloc_flags = flags;
>> void *ret;
>>
>> + if (size > KMALLOC_MAX_SIZE)
>> + goto fallback;
>> +
>> /*
>> * vmalloc uses GFP_KERNEL for some internal allocations (e.g page tables)
>> * so the given set of flags has to be compatible.
>> @@ -422,6 +425,7 @@ void *kvmalloc_node(size_t size, gfp_t flags, int node)
>> if (ret || size <= PAGE_SIZE)
>> return ret;
>>
>> +fallback:
>> return __vmalloc_node_flags_caller(size, node, flags,
>> __builtin_return_address(0));
>> }
>>
>
next prev parent reply other threads:[~2018-11-01 10:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 9:12 [PATCH] mm/kvmalloc: do not confuse kmalloc with page order over MAX_ORDER Konstantin Khlebnikov
2018-11-01 9:33 ` Michal Hocko
2018-11-01 10:09 ` [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE Konstantin Khlebnikov
2018-11-01 10:24 ` Michal Hocko
2018-11-01 10:48 ` Konstantin Khlebnikov [this message]
2018-11-01 12:55 ` Michal Hocko
2018-11-01 16:42 ` Konstantin Khlebnikov
2018-11-01 16:55 ` Michal Hocko
2018-11-05 13:03 ` Vlastimil Babka
2018-11-05 16:19 ` Konstantin Khlebnikov
2018-11-05 16:52 ` Vlastimil Babka
2018-11-05 16:57 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd2a55be-17f1-5da9-1154-8e291fe958cd@yandex-team.ru \
--to=khlebnikov@yandex-team.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).