From: Vlastimil Babka <vbabka@suse.cz>
To: Rik van Riel <riel@surriel.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
linux-kernel@vger.kernel.org
Cc: kernel-team@fb.com, akpm@linux-foundation.org,
linux-mm@kvack.org, mhocko@kernel.org,
mgorman@techsingularity.net, rientjes@google.com,
aarcange@redhat.com, ziy@nvidia.com
Subject: Re: [PATCH v2 2/2] mm,thp,compaction,cma: allow THP migration for CMA allocations
Date: Fri, 28 Feb 2020 15:39:38 +0100 [thread overview]
Message-ID: <ceacd12e-a005-8035-7d88-f79a45a05975@suse.cz> (raw)
In-Reply-To: <47198271414db19cecbfa1a6ea685577dad3a72c.camel@surriel.com>
On 2/28/20 3:32 PM, Rik van Riel wrote:
>>> Does that need to be the following, then?
>>>
>>> if (PageTransHuge(head) && !PageHuge(page) && !PageLRU(head)
>>> &&
>>> !__PageMovable(head))
>>> return page;
>>
>> I would instead make it an "else if" to the "if (PageHuge(page)...)"
>> above.
>
> That was my first thought too, but that could break on
> pages that are PageHuge when hugepage_migration_supported
> returns true.
Right, so then
if (PageHuge()) {
if (!migration_supported) return false;
} else if (!PageLRU(head) ...) {
etc...
IMHO it's better than adding more tests to the second if.
next prev parent reply other threads:[~2020-02-28 14:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 21:32 [PATCH v2 0/2] fix THP migration for CMA allocations Rik van Riel
2020-02-27 21:32 ` [PATCH 1/2] mm,compaction,cma: add alloc_contig flag to compact_control Rik van Riel
2020-02-27 21:32 ` [PATCH v2 2/2] mm,thp,compaction,cma: allow THP migration for CMA allocations Rik van Riel
2020-02-27 23:41 ` Mike Kravetz
2020-02-28 1:21 ` Rik van Riel
2020-02-28 4:30 ` Mike Kravetz
2020-02-28 8:25 ` Vlastimil Babka
2020-02-28 14:32 ` Rik van Riel
2020-02-28 14:39 ` Vlastimil Babka [this message]
2020-02-28 15:47 ` [PATCH] fix mmthpcompactioncma-allow-thp-migration-for-cma-allocations.patch Rik van Riel
2020-03-02 9:32 ` [PATCH v2 2/2] mm,thp,compaction,cma: allow THP migration for CMA allocations Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceacd12e-a005-8035-7d88-f79a45a05975@suse.cz \
--to=vbabka@suse.cz \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).