From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Rob Landley <rob@landley.net>,
Peter Zijlstra <peterz@infradead.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Will Deacon <will.deacon@arm.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Nicholas Piggin <npiggin@gmail.com>,
Linux-Arch <linux-arch@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Rik van Riel <riel@surriel.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v6 10/18] sh/tlb: Convert SH to generic mmu_gather
Date: Wed, 15 Jul 2020 21:49:28 +0200 [thread overview]
Message-ID: <d42ed14e-fbe7-5731-a229-476560995a97@physik.fu-berlin.de> (raw)
In-Reply-To: <e2cf6780-ba7e-d6f6-9d15-92e182f98e84@landley.net>
Hi Rob!
On 12/5/19 8:24 PM, Rob Landley wrote:
> No, but most people running this kind of hardware tend not to upgrade to current
> kernels on a regular basis.
>
> The j-core guys tested the 5.3 release. I can't find an email about 5.4 so I
> dunno if that's been tested yet?
>
> I just tested yesterday's git and it works fine with
> http://lkml.iu.edu/hypermail/linux/kernel/1912.0/01554.html installed, modulo it
> _still_ has the suprious stack dump shortly before calling init, which I've
> complained about on linux-sh and off for a year now?
>
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 1 at mm/slub.c:2451 kmem_cache_free_bulk+0x2c2/0x37c
>
> CPU: 0 PID: 1 Comm: swapper Not tainted 5.4.0 #1
> PC is at kmem_cache_free_bulk+0x2c2/0x37c
> PR is at kmem_cache_alloc_bulk+0x36/0x1a0
> PC : 8c0a6fae SP : 8f829e9c SR : 400080f0
> TEA : c0001240
> R0 : 8c0a6de4 R1 : 00000100 R2 : 00000100 R3 : 00000000
> R4 : 8f8020a0 R5 : 00000dc0 R6 : 8c01d66c R7 : 8fff5180
> R8 : 8c011a00 R9 : 8fff5180 R10 : 8c01d66c R11 : 80000000
> R12 : 00007fff R13 : 00000dc0 R14 : 8f8020a0
> MACH: 0000017a MACL: 0ae4849d GBR : 00000000 PR : 8c0a709e
>
> Call trace:
> [<(ptrval)>] copy_process+0x218/0x1094
> [<(ptrval)>] copy_process+0x7ba/0x1094
> [<(ptrval)>] kmem_cache_alloc_bulk+0x36/0x1a0
> [<(ptrval)>] restore_sigcontext+0x94/0x1b0
> [<(ptrval)>] restore_sigcontext+0x70/0x1b0
> [<(ptrval)>] copy_process+0x218/0x1094
> [<(ptrval)>] sysfs_slab_add+0x106/0x354
> [<(ptrval)>] restore_sigcontext+0x70/0x1b0
> [<(ptrval)>] copy_process+0x218/0x1094
> [<(ptrval)>] copy_process+0x218/0x1094
> [<(ptrval)>] fprop_fraction_single+0x38/0xa4
> [<(ptrval)>] pipe_read+0x7a/0x23c
> [<(ptrval)>] restore_sigcontext+0x70/0x1b0
> [<(ptrval)>] restore_sigcontext+0x94/0x1b0
> [<(ptrval)>] alloc_pipe_info+0x162/0x1c8
> [<(ptrval)>] restore_sigcontext+0x94/0x1b0
> [<(ptrval)>] restore_sigcontext+0x70/0x1b0
> [<(ptrval)>] handle_bad_irq+0x154/0x188
> [<(ptrval)>] raw6_exit_net+0x0/0x14
> [<(ptrval)>] prepare_stack+0xe4/0x2fc
> [<(ptrval)>] sys_sched_get_priority_min+0x18/0x28
> [<(ptrval)>] ndisc_net_exit+0x4/0x24
>
> ---[ end trace 6ce4eefeb577b078 ]---
>
> But it's cosmetic...
This is fixed by the following patch [1]:
sh: Fix unneeded constructor in page table allocation
The pgd kmem_cache allocation both specified __GFP_ZERO and had a
constructor which makes no sense. Remove __GFP_ZERO and zero the user
parts of the pgd explicitly.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Rich Felker <dalias@libc.org>
Adrian
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=73c348f31b63d28d176ed290eb1aa2a648f3e51e
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
next prev parent reply other threads:[~2020-07-15 19:50 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 10:31 [PATCH v6 00/18] generic mmu_gather patches Peter Zijlstra
2019-02-19 10:31 ` [PATCH v6 01/18] asm-generic/tlb: Provide a comment Peter Zijlstra
2019-02-19 10:31 ` [PATCH v6 02/18] asm-generic/tlb: Provide HAVE_MMU_GATHER_PAGE_SIZE Peter Zijlstra
2019-02-19 10:31 ` [PATCH v6 03/18] asm-generic/tlb: Provide generic VIPT cache flush Peter Zijlstra
2019-02-19 10:31 ` [PATCH v6 04/18] asm-generic/tlb: Provide generic tlb_flush() based on flush_tlb_range() Peter Zijlstra
2019-02-19 10:31 ` [PATCH v6 05/18] asm-generic/tlb: Provide generic tlb_flush() based on flush_tlb_mm() Peter Zijlstra
2019-02-19 12:47 ` Will Deacon
2019-02-19 10:31 ` [PATCH v6 06/18] asm-generic/tlb: Conditionally provide tlb_migrate_finish() Peter Zijlstra
2019-02-19 12:47 ` Will Deacon
2019-02-19 13:41 ` Peter Zijlstra
2019-02-20 14:47 ` Will Deacon
2019-02-20 15:02 ` Matthew Wilcox
2019-02-19 10:31 ` [PATCH v6 07/18] asm-generic/tlb: Invert HAVE_RCU_TABLE_INVALIDATE Peter Zijlstra
2019-02-19 10:31 ` [PATCH v6 08/18] arm/tlb: Convert to generic mmu_gather Peter Zijlstra
2019-02-19 10:31 ` [PATCH v6 09/18] ia64/tlb: Conver " Peter Zijlstra
2019-02-19 12:47 ` Will Deacon
2019-02-21 2:52 ` Souptick Joarder
2019-02-19 10:31 ` [PATCH v6 10/18] sh/tlb: Convert SH " Peter Zijlstra
2019-12-03 11:19 ` Geert Uytterhoeven
2019-12-04 10:47 ` Peter Zijlstra
2019-12-04 12:32 ` Geert Uytterhoeven
2019-12-04 13:22 ` Guenter Roeck
2019-12-04 15:17 ` Geert Uytterhoeven
2019-12-04 19:03 ` Guenter Roeck
2019-12-04 13:34 ` Peter Zijlstra
2019-12-04 15:07 ` Geert Uytterhoeven
2019-12-04 16:41 ` Peter Zijlstra
2019-12-05 15:26 ` Geert Uytterhoeven
2020-07-15 19:45 ` John Paul Adrian Glaubitz
2019-12-05 19:24 ` Rob Landley
2019-12-05 19:23 ` Rich Felker
2020-07-15 19:49 ` John Paul Adrian Glaubitz [this message]
2019-12-05 19:30 ` John Paul Adrian Glaubitz
2019-12-05 22:56 ` Guenter Roeck
2019-12-06 13:38 ` John Paul Adrian Glaubitz
2019-12-06 14:03 ` Guenter Roeck
2019-02-19 10:31 ` [PATCH v6 11/18] um/tlb: Convert " Peter Zijlstra
2019-02-19 10:32 ` [PATCH v6 12/18] arch/tlb: Clean up simple architectures Peter Zijlstra
2019-02-19 10:32 ` [PATCH v6 13/18] asm-generic/tlb: Introduce HAVE_MMU_GATHER_NO_GATHER Peter Zijlstra
2019-02-19 12:47 ` Will Deacon
2019-02-19 10:32 ` [PATCH v6 14/18] s390/tlb: convert to generic mmu_gather Peter Zijlstra
2019-02-19 12:47 ` Will Deacon
2019-02-19 10:32 ` [PATCH v6 15/18] asm-generic/tlb: Remove arch_tlb*_mmu() Peter Zijlstra
2019-02-19 10:32 ` [PATCH v6 16/18] asm-generic/tlb: Remove HAVE_GENERIC_MMU_GATHER Peter Zijlstra
2019-02-19 10:32 ` [PATCH v6 17/18] asm-generic/tlb: Remove tlb_flush_mmu_free() Peter Zijlstra
2019-02-19 10:32 ` [PATCH v6 18/18] asm-generic/tlb: Remove tlb_table_flush() Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d42ed14e-fbe7-5731-a229-476560995a97@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dalias@libc.org \
--cc=geert@linux-m68k.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rob@landley.net \
--cc=will.deacon@arm.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).