From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: <mike.kravetz@oracle.com>, <shenkai8@huawei.com>,
<linfeilong@huawei.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <wangwang2@huawei.com>,
"Zhoukang (A)" <zhoukang7@huawei.com>,
Mingfangsen <mingfangsen@huawei.com>, <agl@us.ibm.com>,
<nacc@us.ibm.com>
Subject: Re: [PATCH] mm/hugetlb: Don't put_page in lock of hugetlb_lock
Date: Mon, 6 May 2019 22:05:45 +0800 [thread overview]
Message-ID: <d82df01c-09e8-4e3d-4e01-d4df87936f75@huawei.com> (raw)
In-Reply-To: <20190504130137.GS29835@dhcp22.suse.cz>
> On Sat 04-05-19 20:28:24, Zhiqiang Liu wrote:
>> From: Kai Shen <shenkai8@huawei.com>
>>
>> spinlock recursion happened when do LTP test:
>> #!/bin/bash
>> ./runltp -p -f hugetlb &
>> ./runltp -p -f hugetlb &
>> ./runltp -p -f hugetlb &
>> ./runltp -p -f hugetlb &
>> ./runltp -p -f hugetlb &
>>
>> Fixes: 9980d744a0 ("mm, hugetlb: get rid of surplus page accounting tricks")
>> Signed-off-by: Kai Shen <shenkai8@huawei.com>
>> Signed-off-by: Feilong Lin <linfeilong@huawei.com>
>> Reported-by: Wang Wang <wangwang2@huawei.com>
>
> You are right. I must have completely missed that put_page path
> unconditionally takes the hugetlb_lock for hugetlb pages.
>
> Thanks for fixing this. I think this should be marked for stable
> because it is not hard to imagine a regular user might trigger this.
>
> Acked-by: Michal Hocko <mhocko@suse.com>
Thank you for your reply.
I will add Acked-by: Michal Hocko <mhocko@suse.com> in the v2 patch.
next prev parent reply other threads:[~2019-05-06 14:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 12:28 [PATCH] mm/hugetlb: Don't put_page in lock of hugetlb_lock Zhiqiang Liu
2019-05-04 13:01 ` Michal Hocko
2019-05-06 14:05 ` Zhiqiang Liu [this message]
2019-05-06 14:06 ` [PATCH v2] " Zhiqiang Liu
2019-05-06 14:20 ` Michal Hocko
2019-05-06 15:22 ` Zhiqiang Liu
2019-05-06 19:07 ` Michal Hocko
2019-05-07 3:25 ` Zhiqiang Liu
2019-05-06 14:48 ` Oscar Salvador
2019-05-06 17:19 ` Mike Kravetz
2019-05-08 11:31 ` Zhiqiang Liu
2019-05-09 22:54 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d82df01c-09e8-4e3d-4e01-d4df87936f75@huawei.com \
--to=liuzhiqiang26@huawei.com \
--cc=agl@us.ibm.com \
--cc=linfeilong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=mingfangsen@huawei.com \
--cc=nacc@us.ibm.com \
--cc=shenkai8@huawei.com \
--cc=wangwang2@huawei.com \
--cc=zhoukang7@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).