Re: [PATCH v4 7/7] hugetlb: parallelize 1G hugetlb initialization

From: Gang Li <gang.li@linux.dev>
To: Muchun Song <muchun.song@linux.dev>
Cc: Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	ligang.bdlg@bytedance.com, David Hildenbrand <david@redhat.com>,
	David Rientjes <rientjes@google.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tim Chen <tim.c.chen@linux.intel.com>
Subject: Re: [PATCH v4 7/7] hugetlb: parallelize 1G hugetlb initialization
Date: Thu, 25 Jan 2024 11:56:21 +0800	[thread overview]
Message-ID: <dd483e40-f6ad-4fc2-bfc8-468d93e07ea9@linux.dev> (raw)
In-Reply-To: <15E775EC-8E4B-4145-8931-067DF60E55F1@linux.dev>

On 2024/1/25 10:48, Muchun Song wrote:
>>>> +    if (huge_boot_pages[0].next == NULL) {
>>> It it not intuitive. I'd like to use a 'initialied' variable
>>
>> Would it make the code look a bit redundant?
> 
> What is redundant?
> 

I was thinking of adding a global variable at first, but it's possible
to add a local static variable, which is more concise.