From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C8BAC76196 for ; Tue, 11 Apr 2023 01:35:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E61A0280047; Mon, 10 Apr 2023 21:35:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DEB0428003C; Mon, 10 Apr 2023 21:35:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8A9D280047; Mon, 10 Apr 2023 21:35:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B6B9C28003C for ; Mon, 10 Apr 2023 21:35:24 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7B5FEABF63 for ; Tue, 11 Apr 2023 01:35:24 +0000 (UTC) X-FDA: 80667392568.27.3850983 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) by imf04.hostedemail.com (Postfix) with ESMTP id BE53040012 for ; Tue, 11 Apr 2023 01:35:22 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ckDnI+qY; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of 3Wbk0ZAsKCMYmowq3xqA5zss00sxq.o0yxuz69-yyw7mow.03s@flex--ackerleytng.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3Wbk0ZAsKCMYmowq3xqA5zss00sxq.o0yxuz69-yyw7mow.03s@flex--ackerleytng.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681176922; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=P3v7tjSHGZNeYf6fkHAGvkufX/1T+vrTWm+HxnUGut4=; b=lFQ1wSsLb3fGqp0WFgYCa4dagyizcwVEfVLx51v2dbHrDHHvgudz3tZehnl95J50XZIE3D nmBCdzwTZLvglcrZ9kVi+yjAWCWnIRYvtSghgcGdj5Bx4B59z5P0y593ifHY3fTlmE9eDl eDNwzjAJVA4Zh2sTJsJ6TDNULHHYkvA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ckDnI+qY; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of 3Wbk0ZAsKCMYmowq3xqA5zss00sxq.o0yxuz69-yyw7mow.03s@flex--ackerleytng.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3Wbk0ZAsKCMYmowq3xqA5zss00sxq.o0yxuz69-yyw7mow.03s@flex--ackerleytng.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681176922; a=rsa-sha256; cv=none; b=Zh7Ti+qTtQMJCRtB8QOElLMDLC/8jHCx8dhVMfoRdFQvKy1hkBO6wj+WaRkovEX534xCpu KuixgHMzrSE0m5D7N1WHuKcxYImoufW6xvNCYcvtLrgXgz09r56+jNKKo+RjDY6X9/jqqQ Xx4pRxmQgsBVJ4X5xMfRD7exypVuS4g= Received: by mail-pg1-f202.google.com with SMTP id l69-20020a638848000000b00519e800366eso1714637pgd.19 for ; Mon, 10 Apr 2023 18:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1681176921; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date:from:to :cc:subject:date:message-id:reply-to; bh=P3v7tjSHGZNeYf6fkHAGvkufX/1T+vrTWm+HxnUGut4=; b=ckDnI+qYpROoTcufCDcwOgr9iK1RPksPsWmIOeBsLNA/uyUeqNZdzhUf9sXthlctPf F+wMi3ClOnexsABXRbEypc3cqMNPH6Z0tNPVuwd8fhbDH8ln+SkWrpjNxEGwPxC/2glt FMI52wFhtuuDKkOMoaifJqIS9sTG7C5BknJRLtVbUZ9NqSkywnTZ/Opexpr9pbApTgcj GvPQtEzR7qQ4/fxydRQd5pWtJ5dgkv7JwSBfm07pT8ToRPItu6TrUnHKJfJ+avfBnkLl UgRpWyM2oduh/jLdoDELNXyYnRgcaaN+uD3VPgKEYl1EqI5ru4nTcuI8zBQ1sZRVNTWk QFdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681176921; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P3v7tjSHGZNeYf6fkHAGvkufX/1T+vrTWm+HxnUGut4=; b=lR7nf5lDx1TGoqfMqsppEqib200jss0NOGYO6bXsVvOgq+qiIDlp/EVXe52Y/v6PAe IjUMdOsw4WhNLaEVnEF4Eh0J6BFhP2gl1EeQvjof9ESRyrT4ifPda58+TuTlzhpFtmNl lyaxptqvEk/570zAoAIaZL9czfieAwmjpr7SopeU0AYpUyNXPoefWbqoPDzQ7Rh6r8qD TjrTTmVBdOkkiEaNOP5xvwPiaIbipYygLXlYpuxcVVvLKRigt92ZWysBEjAB4Zg36YE6 OZ3vq6dwmogeu+l49n4tPE+zSGBmY6K4Dic38+6J0IiNfx08bDH5KKnVPTlXc4kPPxKb VZlA== X-Gm-Message-State: AAQBX9e+0k7VXl2nW8Ls9vrlb+z4aMKXkceLD0R5E+xz13GhRBA/A4cO tzsuURnWN9od7JPMnRVhA8tGhmYOtw/DgFtrdA== X-Google-Smtp-Source: AKy350ZpEpeQ13YWXEI6KoaJD09D+A99JikQlgyPpvIj63sO7he4qmnLCAo5joZFqabrZuaV6dwRVFPxHRliUjWyCg== X-Received: from ackerleytng-cloudtop.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:1f5f]) (user=ackerleytng job=sendgmr) by 2002:a63:4c1c:0:b0:518:1f4d:3dbc with SMTP id z28-20020a634c1c000000b005181f4d3dbcmr213711pga.10.1681176921489; Mon, 10 Apr 2023 18:35:21 -0700 (PDT) Date: Tue, 11 Apr 2023 01:35:20 +0000 In-Reply-To: <9bbdc378-e66e-0a44-244b-33dffe888a2b@redhat.com> (message from David Hildenbrand on Mon, 3 Apr 2023 10:24:37 +0200) Mime-Version: 1.0 Message-ID: Subject: Re: [RFC PATCH v3 2/2] selftests: restrictedmem: Check hugepage-ness of shmem file backing restrictedmem fd From: Ackerley Tng To: David Hildenbrand Cc: kvm@vger.kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, qemu-devel@nongnu.org, aarcange@redhat.com, ak@linux.intel.com, akpm@linux-foundation.org, arnd@arndb.de, bfields@fieldses.org, bp@alien8.de, chao.p.peng@linux.intel.com, corbet@lwn.net, dave.hansen@intel.com, ddutile@redhat.com, dhildenb@redhat.com, hpa@zytor.com, hughd@google.com, jlayton@kernel.org, jmattson@google.com, joro@8bytes.org, jun.nakajima@intel.com, kirill.shutemov@linux.intel.com, linmiaohe@huawei.com, luto@kernel.org, mail@maciej.szmigiero.name, mhocko@suse.com, michael.roth@amd.com, mingo@redhat.com, naoya.horiguchi@nec.com, pbonzini@redhat.com, qperret@google.com, rppt@kernel.org, seanjc@google.com, shuah@kernel.org, steven.price@arm.com, tabba@google.com, tglx@linutronix.de, vannapurve@google.com, vbabka@suse.cz, vkuznets@redhat.com, wanpengli@tencent.com, wei.w.wang@intel.com, x86@kernel.org, yu.c.zhang@linux.intel.com Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes X-Rspamd-Queue-Id: BE53040012 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: ya84ha498qzdak3dxgb8goa18z7fksqn X-HE-Tag: 1681176922-915641 X-HE-Meta: U2FsdGVkX18Hb5OJuR82WY9NksWmr48ciTZd95QjhWpPnblZjbnFpRYey5k0YphiDbhfKSYUgjV8JQtDC6Wp3txzwYkW0uu+w7nUIAmcJyAioJa2G2pxbpjkrhW7J+8YdwRP0dPpRQBgVCy3rLo8837TyA9ve9gRQcqjc8iokZ/Gm1A9tInzqeYwdauxaCq3CzIsiUMd/PYAjWWjLVYSTQbVgHRioFFov19x2894KWpQb0fb5ZZ8dtUATK3z+Fub1piFvVwcshuSbLQ+Wr9PbTy5rPKt0z3NNMAfwxzcx4msmDMSqIlAU9ErrXNMJLsiZF6eCT5xqbHqiMP6kMp1dYV3IQmia/SE141hiH1ivviNal5RYgdogK6Iqq2/uFtHFKT0hn9a9P1LAucodXwtuB2CYBl/7c97yp3wicQsWVa+fbaRkF5K1hWfwpCmHF3LLbfRAWKLmF7b/N5pPXATQOpzJRxZtpG3XN3d6ltF2nV3vNxxNf5A268k98URSwoJxnr3MTSUfCscvEFg/3Z05SNBBZxPrAlEXdovmpRiLcfxxLALIoex4iH/NzkbLWiWt9SS2l/kvKMhkJZALrI0KV88r1yndagJIKjCXqjJqwekxCMinNy98ToykiZJxotEontomwiDbg/h+ZVTOsGcrc6EDi3copx5hP3gPi6qnDiN5slG8jaQn3cTMg3l0pKoHEivv0U6UBd2qWthPLaJJ8EuPFfWaCrnHjYfM49Ko0R+bObUh9Smln0UIc7bpWnsG0LKTpk79oh1XU1THHHn+rzlINygHvR+iToLC+oY3P39eb5J4xbGgc9Hf8k7//rBahyEvT/ilXzBkKkI0qHeau80DNKWoC/CHvwL/NN9JcFJy8I1NGrjb4yc7bpLxexwDCwOj7pVMYbz3ul35HW4dgMS45m0/xbV6ggYTwWFKANhBYCTjy8zYT2NesUjeGPYGsjQiy7mC3bIm4+q8ae X7Z0gYLb KPFB+mrdd0php83mgXQZw6xwCFwzHy2MOG8AvcAlT8YOXCEe6haKMiYyxf/9foqnD/d/5tqXMpXZA8yAD0tQGSfzubVDD+MApsoDoIZfrOYz2G/Yw13DZrzg5zooJWHlC7ZW7RPmMJQk+z2XPRFhCLIq7seCLXtRGpcLNc3O/yCvXFgfvbuoaQ7NBcSwtIXjhO/epOjmypnKwQjHgUAYSHa8al3rZPagyHfAwDK7RvNWBbhtZrHEkfoDG+mZ1SDc2J3oGSZ1tEzmisG/dV3mLduz0rpz/SOtSQSEtJhxSMLrtFjwpytrc0BtBoCW1cGwJxT7ynTWXHZgvhDsClvaPAIj3O1QuMzjqSE0olbJxQjs6SPdFiwgpi0/Vf5Yy099Pi6TeuWd582IUfwddn2KMxa8Y9HwnNl6b+WArlaUqb6XUgsmlwOBDM9d1zJxWJ9NyBxS/+iOdVPV/prLMaUYitFuVFXhzTWxpth8iKIeoaMy5h5JXNhJoacYcBjB0eCFyWEhYE5kho9nyyawMfoPov2w8eImrRMT0ErjGs3SdV/BVwMDqBLyxehZYH6lZ9xAP8j0nRWCN58PDYDJKZ7Qidn4N9pBYgwsc8YvlbBWFQZphVsPV7jex5kUTZMqRO6IhIAk6p+WRB5l7FjYx3Kd59CZu1z65fei8yjqtbbhsP/Do2Lth0MK4HT1u9byVMzlRxFgSFXX7qKgGqAGbGGWscK8pefXBGKyEE9Wl+mgBIYTZqY6WH3YX8Al3dg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Hildenbrand writes: > On 01.04.23 01:50, Ackerley Tng wrote: >> For memfd_restricted() calls without a userspace mount, the backing >> file should be the shmem mount in the kernel, and the size of backing >> pages should be as defined by system-wide shmem configuration. >> If a userspace mount is provided, the size of backing pages should be >> as defined in the mount. >> Also includes negative tests for invalid inputs, including fds >> representing read-only superblocks/mounts. > When you talk about "hugepage" in this patch, do you mean THP or > hugetlb? I suspect thp, so it might be better to spell that out. IIRC, > there are plans to support actual huge pages in the future, at which > point "hugepage" terminology could be misleading. Thanks for pointing this out! I've replaced references to hugepage with thp, please see RFC v4 at https://lore.kernel.org/lkml/cover.1681176340.git.ackerleytng@google.com/T/ >> Signed-off-by: Ackerley Tng >> --- >> tools/testing/selftests/Makefile | 1 + >> .../selftests/restrictedmem/.gitignore | 3 + >> .../testing/selftests/restrictedmem/Makefile | 15 + >> .../testing/selftests/restrictedmem/common.c | 9 + >> .../testing/selftests/restrictedmem/common.h | 8 + >> .../restrictedmem_hugepage_test.c | 486 ++++++++++++++++++ >> 6 files changed, 522 insertions(+) >> create mode 100644 tools/testing/selftests/restrictedmem/.gitignore >> create mode 100644 tools/testing/selftests/restrictedmem/Makefile >> create mode 100644 tools/testing/selftests/restrictedmem/common.c >> create mode 100644 tools/testing/selftests/restrictedmem/common.h >> create mode 100644 >> tools/testing/selftests/restrictedmem/restrictedmem_hugepage_test.c >> ...