From: Mike Kravetz <mike.kravetz@oracle.com>
To: "Li Xinhai" <lixinhai.lxh@gmail.com>,
"HORIGUCHI NAOYA (堀口 直也)" <naoya.horiguchi@nec.com>
Cc: n-horiguchi <n-horiguchi@ah.jp.nec.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
akpm <akpm@linux-foundation.org>, mhocko <mhocko@suse.com>,
linux-man <linux-man@vger.kernel.org>
Subject: Re: [PATCH] mm/mempolicy: support MPOL_MF_STRICT for huge page mapping
Date: Wed, 12 Feb 2020 15:50:07 -0800 [thread overview]
Message-ID: <e135a4d1-c713-2003-13ea-f8b5695a7745@oracle.com> (raw)
In-Reply-To: <2020021213250278382352@gmail.com>
On 2/11/20 9:25 PM, Li Xinhai wrote:
> On 2020-02-12 at 11:21 HORIGUCHI NAOYA(堀口 直也) wrote:
>> On Mon, Feb 10, 2020 at 09:19:48AM -0800, Mike Kravetz wrote:
>>> On 1/30/20 5:33 PM, Li Xinhai wrote:
>> ...
>>>>
>>>> Signed-off-by: Li Xinhai <lixinhai.lxh@gmail.com>
>>>> Cc: Michal Hocko <mhocko@suse.com>
>>>> Cc: Mike Kravetz <mike.kravetz@oracle.com>
>>>> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>>>> Cc: linux-man <linux-man@vger.kernel.org>
>>>
>>> Hello Naoya,
>>>
>>> Do you have any thoughts on this? In previous discussions you suggested this
>>> approach of removing the special casing for hugetlb pages. The code looks
>>> good to me and patch is fine with commmit message modification. Just wanted
>>> to get your opinion.
>>
>> Hi Mike, Xinhai,
>>
>> The suggested change looks good to me, too.
>>
>> Thanks,
>> Naoya Horiguchi
>
> Naoya, thanks for inspecting the change!
Can you please send V2 of patch with an updated commit message.
I would like the section that which lists the impact to "users using
MPOL_MF_STRICT alone" to say something like this:
If MPOL_MF_STRICT alone was previously used, hugetlb pages not following the
memory policy would not cause an EIO error. After this change, hugetlb pages
are treated like all other pages. If MPOL_MF_STRICT alone is used and hugetlb
pages do not follow memory policy an EIO error will be returned.
--
Mike Kravetz
next prev parent reply other threads:[~2020-02-12 23:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 1:33 [PATCH] mm/mempolicy: support MPOL_MF_STRICT for huge page mapping Li Xinhai
2020-02-01 3:28 ` Mike Kravetz
2020-02-01 13:56 ` Li Xinhai
2020-02-10 17:19 ` Mike Kravetz
2020-02-12 3:21 ` HORIGUCHI NAOYA(堀口 直也)
2020-02-12 5:25 ` Li Xinhai
2020-02-12 23:50 ` Mike Kravetz [this message]
2020-02-13 1:50 ` Li Xinhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e135a4d1-c713-2003-13ea-f8b5695a7745@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lixinhai.lxh@gmail.com \
--cc=mhocko@suse.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=naoya.horiguchi@nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).