From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66274C56201 for ; Wed, 25 Nov 2020 17:27:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9CC6E21D40 for ; Wed, 25 Nov 2020 17:27:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UYRqLH0W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CC6E21D40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B54806B0070; Wed, 25 Nov 2020 12:27:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B05A16B0071; Wed, 25 Nov 2020 12:27:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1A3C6B0072; Wed, 25 Nov 2020 12:27:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0136.hostedemail.com [216.40.44.136]) by kanga.kvack.org (Postfix) with ESMTP id 8E9F76B0070 for ; Wed, 25 Nov 2020 12:27:31 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 51045180AD815 for ; Wed, 25 Nov 2020 17:27:31 +0000 (UTC) X-FDA: 77523622302.08.burst40_0c057c727378 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 313131819E76C for ; Wed, 25 Nov 2020 17:27:31 +0000 (UTC) X-HE-Tag: burst40_0c057c727378 X-Filterd-Recvd-Size: 4491 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 17:27:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606325249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=128QzWN5ZV6H8TGg9AgMhcOfUvIwMfuRP45rtKXIJzc=; b=UYRqLH0WVDT+3ZqUIdJCRMlZ3jrNjKtUGrF4KtmgptJwIq5kLt2nqIybVHLZSXdQkWS704 t2BTLalaWAESxPn0UHOkX4jVG32CuezuiQw3C0mki4N8Fd+gzECpgVZpYLKsPUfE8eTskK YdT1e+I6JFCyU9obO7Xm3BIZgBmZsQE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-VZlW4DNdMHaUwzfL9ixwkA-1; Wed, 25 Nov 2020 12:27:24 -0500 X-MC-Unique: VZlW4DNdMHaUwzfL9ixwkA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 95D7D1087D6C; Wed, 25 Nov 2020 17:27:20 +0000 (UTC) Received: from [10.36.112.131] (ovpn-112-131.ams2.redhat.com [10.36.112.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id 18B3260BE5; Wed, 25 Nov 2020 17:27:18 +0000 (UTC) Subject: Re: [RFC 3/3] s390/mm: Define arch_get_addressable_range() To: Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org Cc: Heiko Carstens , Vasily Gorbik , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <1606098529-7907-1-git-send-email-anshuman.khandual@arm.com> <1606098529-7907-4-git-send-email-anshuman.khandual@arm.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Wed, 25 Nov 2020 18:27:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <1606098529-7907-4-git-send-email-anshuman.khandual@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.11.20 03:28, Anshuman Khandual wrote: > This overrides arch_get_addressable_range() on s390 platform and drops > now redudant similar check in vmem_add_mapping(). > > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: David Hildenbrand > Cc: linux-s390@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > arch/s390/include/asm/mmu.h | 2 ++ > arch/s390/mm/vmem.c | 16 ++++++++++++---- > 2 files changed, 14 insertions(+), 4 deletions(-) > > diff --git a/arch/s390/include/asm/mmu.h b/arch/s390/include/asm/mmu.h > index e12ff0f29d1a..f92d3926b188 100644 > --- a/arch/s390/include/asm/mmu.h > +++ b/arch/s390/include/asm/mmu.h > @@ -55,4 +55,6 @@ static inline int tprot(unsigned long addr) > return rc; > } > > +#define arch_get_addressable_range arch_get_addressable_range > +struct range arch_get_addressable_range(bool need_mapping); > #endif > diff --git a/arch/s390/mm/vmem.c b/arch/s390/mm/vmem.c > index b239f2ba93b0..e03ad0ed13a7 100644 > --- a/arch/s390/mm/vmem.c > +++ b/arch/s390/mm/vmem.c > @@ -532,14 +532,22 @@ void vmem_remove_mapping(unsigned long start, unsigned long size) > mutex_unlock(&vmem_mutex); > } > > +struct range arch_get_addressable_range(bool need_mapping) > +{ > + struct range memhp_range; > + > + memhp_range.start = 0; > + if (need_mapping) > + memhp_range.end = VMEM_MAX_PHYS; > + else > + memhp_range.end = (1ULL << (MAX_PHYSMEM_BITS + 1)) - 1; > + return memhp_range; > +} > + > int vmem_add_mapping(unsigned long start, unsigned long size) > { > int ret; > > - if (start + size > VMEM_MAX_PHYS || > - start + size < start) > - return -ERANGE; > - > mutex_lock(&vmem_mutex); > ret = vmem_add_range(start, size); > if (ret) > Note that vmem_add_mapping() is also called from extmem (arch/s390/mm/extmem.c). -- Thanks, David / dhildenb