From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
jfs-discussion@lists.sourceforge.net,
linux-nvme@lists.infradead.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
dm-devel@redhat.com, target-devel@vger.kernel.org,
linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
linux-um@lists.infradead.org, nbd@other.debian.org,
linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
linux-mmc@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev,
linux-btrfs@vger.kernel.org
Subject: Re: [dm-devel] [PATCH 01/27] target: remove an incorrect unmap zeroes data deduction
Date: Wed, 06 Apr 2022 23:06:16 -0400 [thread overview]
Message-ID: <yq1r169k2xu.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20220406060516.409838-2-hch@lst.de> (Christoph Hellwig's message of "Wed, 6 Apr 2022 08:04:50 +0200")
Christoph,
> For block devices the target code implements UNMAP as calls to
> blkdev_issue_discard, which does not guarantee zeroing just because
> Write Zeroes is supported.
>
> Note that this does not affect the file backed path which uses
> fallocate to punch holes.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-04-07 3:07 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 6:04 use block_device based APIs in block layer consumers Christoph Hellwig
2022-04-06 6:04 ` [PATCH 01/27] target: remove an incorrect unmap zeroes data deduction Christoph Hellwig
2022-04-07 3:05 ` [dm-devel] " Martin K. Petersen
2022-04-07 3:06 ` Martin K. Petersen [this message]
2022-04-06 6:04 ` [PATCH 02/27] target: pass a block_device to target_configure_unmap_from_queue Christoph Hellwig
2022-04-07 3:07 ` Martin K. Petersen
2022-04-06 6:04 ` [PATCH 03/27] target: fix discard alignment on partitions Christoph Hellwig
2022-04-07 3:14 ` [dm-devel] " Martin K. Petersen
2022-04-06 6:04 ` [PATCH 05/27] drbd: use bdev based limit helpers in drbd_send_sizes Christoph Hellwig
2022-04-06 6:04 ` [PATCH 06/27] drbd: cleanup decide_on_discard_support Christoph Hellwig
2022-04-06 6:04 ` [PATCH 07/27] btrfs: use bdev_max_active_zones instead of open coding it Christoph Hellwig
2022-04-06 9:56 ` Johannes Thumshirn
2022-04-07 15:20 ` David Sterba
2022-04-07 15:26 ` Christoph Hellwig
2022-04-06 6:04 ` [PATCH 08/27] ntfs3: use bdev_logical_block_size " Christoph Hellwig
2022-04-06 6:04 ` [PATCH 09/27] mm: use bdev_is_zoned in claim_swapfile Christoph Hellwig
2022-04-06 6:04 ` [PATCH 10/27] block: add a bdev_nonrot helper Christoph Hellwig
2022-04-07 3:16 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-07 15:21 ` David Sterba
2022-04-06 6:05 ` [PATCH 11/27] block: add a bdev_write_cache helper Christoph Hellwig
2022-04-07 3:17 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-07 15:21 ` David Sterba
2022-04-06 6:05 ` [PATCH 12/27] block: add a bdev_fua helper Christoph Hellwig
2022-04-07 3:17 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 13/27] block: add a bdev_stable_writes helper Christoph Hellwig
2022-04-07 3:18 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 14/27] block: add a bdev_max_zone_append_sectors helper Christoph Hellwig
2022-04-06 8:52 ` Damien Le Moal
2022-04-06 9:58 ` Johannes Thumshirn
2022-04-07 3:15 ` [dm-devel] " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 15/27] block: use bdev_alignment_offset in part_alignment_offset_show Christoph Hellwig
2022-04-07 3:19 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 16/27] drbd: use bdev_alignment_offset instead of queue_alignment_offset Christoph Hellwig
2022-04-06 6:05 ` [PATCH 17/27] block: use bdev_alignment_offset in disk_alignment_offset_show Christoph Hellwig
2022-04-07 3:20 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 18/27] block: move bdev_alignment_offset and queue_limit_alignment_offset out of line Christoph Hellwig
2022-04-07 3:21 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 19/27] block: remove queue_discard_alignment Christoph Hellwig
2022-04-07 3:21 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 20/27] block: use bdev_discard_alignment in part_discard_alignment_show Christoph Hellwig
2022-04-07 3:22 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 21/27] block: move {bdev,queue_limit}_discard_alignment out of line Christoph Hellwig
2022-04-07 3:27 ` [Ocfs2-devel] [PATCH 21/27] block: move {bdev, queue_limit}_discard_alignment " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 22/27] block: refactor discard bio size limiting Christoph Hellwig
2022-04-07 3:29 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-07 8:03 ` Coly Li
2022-04-06 6:05 ` [PATCH 23/27] block: add a bdev_max_discard_sectors helper Christoph Hellwig
2022-04-06 9:53 ` [Cluster-devel] " Andreas Gruenbacher
2022-04-06 17:28 ` Ryusuke Konishi
2022-04-07 3:30 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-07 5:16 ` Coly Li
2022-04-07 15:22 ` David Sterba
2022-04-06 6:05 ` [PATCH 24/27] block: add a bdev_discard_granularity helper Christoph Hellwig
2022-04-06 18:26 ` Ryusuke Konishi
2022-04-07 3:32 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-07 15:26 ` David Sterba
2022-04-06 6:05 ` [PATCH 25/27] block: remove QUEUE_FLAG_DISCARD Christoph Hellwig
2022-04-07 3:34 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-07 5:18 ` Coly Li
2022-04-06 6:05 ` [PATCH 26/27] block: uncouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD Christoph Hellwig
2022-04-07 3:36 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-07 6:09 ` Coly Li
2022-04-07 7:01 ` Ryusuke Konishi
2022-04-07 15:26 ` David Sterba
2022-04-11 18:24 ` [f2fs-dev] " Jaegeuk Kim
2022-04-06 6:05 ` [PATCH 27/27] direct-io: remove random prefetches Christoph Hellwig
[not found] ` <0b7ae3df301c4fdd8d37f773d8d1eb93@FR3P281MB0843.DEUP281.PROD.OUTLOOK.COM>
2022-04-06 7:04 ` [PATCH 15/27] block: use bdev_alignment_offset in part_alignment_offset_show Alan Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1r169k2xu.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=cluster-devel@redhat.com \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@lst.de \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=ntfs3@lists.linux.dev \
--cc=ocfs2-devel@oss.oracle.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).