From: Rob Herring <robh@kernel.org>
To: Kangmin Park <l4stpr0gr4m@gmail.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: Convert sdhci-sirf to json-schema
Date: Wed, 15 Jul 2020 16:06:34 -0600 [thread overview]
Message-ID: <20200715220634.GA897068@bogus> (raw)
In-Reply-To: <20200706174336.27251-1-l4stpr0gr4m@gmail.com>
On Tue, Jul 07, 2020 at 02:43:36AM +0900, Kangmin Park wrote:
> Convert the sdhci-sirf binding to DT schema format using json-schema.
>
> At the same time, fix unit address to match the first address specified
> in the reg property of the node.
>
> Signed-off-by: Kangmin Park <l4stpr0gr4m@gmail.com>
> ---
> .../devicetree/bindings/mmc/sdhci-sirf.txt | 18 ---------
> .../devicetree/bindings/mmc/sdhci-sirf.yaml | 40 +++++++++++++++++++
> 2 files changed, 40 insertions(+), 18 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mmc/sdhci-sirf.txt
> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-sirf.yaml
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-sirf.txt b/Documentation/devicetree/bindings/mmc/sdhci-sirf.txt
> deleted file mode 100644
> index dd6ed464bcb8..000000000000
> --- a/Documentation/devicetree/bindings/mmc/sdhci-sirf.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -* SiRFprimII/marco/atlas6 SDHCI Controller
> -
> -This file documents differences between the core properties in mmc.txt
> -and the properties used by the sdhci-sirf driver.
> -
> -Required properties:
> -- compatible: sirf,prima2-sdhc
> -
> -Optional properties:
> -- cd-gpios: card detect gpio, with zero flags.
> -
> -Example:
> -
> - sd0: sdhci@56000000 {
> - compatible = "sirf,prima2-sdhc";
> - reg = <0xcd000000 0x100000>;
> - cd-gpios = <&gpio 6 0>;
> - };
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-sirf.yaml b/Documentation/devicetree/bindings/mmc/sdhci-sirf.yaml
> new file mode 100644
> index 000000000000..46269378d9b6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-sirf.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/sdhci-sirf.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sdhci Sirf Device Tree Bindings
> +
> +description: |
> + This file documents differences between the core properties in
> + mmc.txt and the properties used by the sdhci-sirf driver.
> +
> +maintainers:
> + - Ulf Hansson <ulf.hansson@linaro.org>
Normally, this should be someone familar with the h/w, not the MMC
maintainer.
Needs a reference to mmc-controller.yaml.
> +
> +properties:
> + compatible:
> + enum:
> + - sirf,prima2-sdhc
> +
> + reg:
> + maxItems: 1
> +
> + cd-gpios:
> + description:
> + card detect gpio, with zero flags.
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + sd0: sdhci@cd000000 {
> + compatible = "sirf,prima2-sdhc";
> + reg = <0xcd000000 0x100000>;
> + cd-gpios = <&gpio 6 0>;
> + };
> --
> 2.26.2
>
prev parent reply other threads:[~2020-07-15 22:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 17:43 [PATCH] dt-bindings: mmc: Convert sdhci-sirf to json-schema Kangmin Park
2020-07-15 22:06 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715220634.GA897068@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=l4stpr0gr4m@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).