From: Marcin Wojtas <mw@semihalf.com>
To: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Cc: ulf.hansson@linaro.org, huziji@marvell.com,
adrian.hunter@intel.com, jaz@semihalf.com, tn@semihalf.com,
kostap@marvell.com, Alex Leibovich <alexl@marvell.com>,
Marcin Wojtas <mw@semihalf.com>,
stable@vger.kernel.org
Subject: [PATCH] mmc: sdhci-xenon: fix 1.8v regulator stabilization
Date: Fri, 11 Dec 2020 15:16:56 +0100 [thread overview]
Message-ID: <20201211141656.24915-1-mw@semihalf.com> (raw)
From: Alex Leibovich <alexl@marvell.com>
Automatic Clock Gating is a feature used for the power
consumption optimisation. It turned out that
during early init phase it may prevent the stable voltage
switch to 1.8V - due to that on some platfroms an endless
printout in dmesg can be observed:
"mmc1: 1.8V regulator output did not became stable"
Fix the problem by disabling the ACG at very beginning
of the sdhci_init and let that be enabled later.
Fixes: 3a3748dba881 ("mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality")
Signed-off-by: Alex Leibovich <alexl@marvell.com>
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Cc: stable@vger.kernel.org
---
drivers/mmc/host/sdhci-xenon.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-xenon.c b/drivers/mmc/host/sdhci-xenon.c
index c67611fdaa8a..4b05f6fdefb4 100644
--- a/drivers/mmc/host/sdhci-xenon.c
+++ b/drivers/mmc/host/sdhci-xenon.c
@@ -168,7 +168,12 @@ static void xenon_reset_exit(struct sdhci_host *host,
/* Disable tuning request and auto-retuning again */
xenon_retune_setup(host);
- xenon_set_acg(host, true);
+ /*
+ * The ACG should be turned off at the early init time, in order
+ * to solve a possile issues with the 1.8V regulator stabilization.
+ * The feature is enabled in later stage.
+ */
+ xenon_set_acg(host, false);
xenon_set_sdclk_off_idle(host, sdhc_id, false);
--
2.29.0
next reply other threads:[~2020-12-12 1:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 14:16 Marcin Wojtas [this message]
2020-12-15 8:03 ` [PATCH] mmc: sdhci-xenon: fix 1.8v regulator stabilization Adrian Hunter
2020-12-15 9:17 ` Marcin Wojtas
2021-01-11 18:06 ` Ulf Hansson
2022-03-14 15:40 ` Pali Rohár
2022-03-14 15:51 ` Marcin Wojtas
2022-03-15 23:03 ` Pali Rohár
2022-03-16 1:03 ` Marcin Wojtas
2022-03-18 13:01 ` Pali Rohár
2022-03-18 13:06 ` Pali Rohár
2022-03-18 13:39 ` Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211141656.24915-1-mw@semihalf.com \
--to=mw@semihalf.com \
--cc=adrian.hunter@intel.com \
--cc=alexl@marvell.com \
--cc=huziji@marvell.com \
--cc=jaz@semihalf.com \
--cc=kostap@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tn@semihalf.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).