linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Liming Sun <limings@nvidia.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: Question about mmc_blk_issue_flush() failure and recovery in Linux kernel
Date: Mon, 13 May 2024 07:58:55 +0300	[thread overview]
Message-ID: <579d5e7a-0745-4598-9d1d-ac951992a549@intel.com> (raw)
In-Reply-To: <BN9PR12MB5068667F4108339D4B140274D3E22@BN9PR12MB5068.namprd12.prod.outlook.com>

On 13/05/24 05:47, Liming Sun wrote:

Please cc linux-mmc mailing list.  Others may be able to help
or have similar issues.

> I saw that Linux emmc/block has recovery mechanism, but somehow a path like below doesn’t seem to trigger it.
>  
> [  285.858838] mmc0: cache flush error -110

Cache flush error means any data in the cache will be lost.

Generally, this is already unacceptable i.e. recovery from
here is not a priority because we shouldn't get here.

Also the file system may be corrupt, and there doesn't seem
to be anything the mmc subsystem can do about that.

> [  285.862776] blk_update_request: I/O error, dev mmcblk0, sector 42002577 op 0x1:(WRITE) flags 0x29800 phys_seg 1 prio class 0
> [  285.874006] XFS (mmcblk0p3): log I/O error -5
> [  285.878369] XFS (mmcblk0p3): Log I/O Error Detected. Shutting down filesystem
> [  285.885489] XFS (mmcblk0p3): Please unmount the filesystem and rectify the problem(s)

To recovery from here probably means
	unmount the file system
	fix it
	unbind and rebind the eMMC host controller

> From the code, it might be called from mmc_blk_mq_issue_rq() à MMC_ISSUE_SYNC/REQ_OP_FLUSH à mmc_blk_issue_flush() which fails.
>  
> Would it make sense to trigger emmc recovery for this path or any suggestion how to do it?

Generally the priority would be preventing the cache
flush error.  To start with, identify what is causing
it.


       reply	other threads:[~2024-05-13  4:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BN9PR12MB5068667F4108339D4B140274D3E22@BN9PR12MB5068.namprd12.prod.outlook.com>
2024-05-13  4:58 ` Adrian Hunter [this message]
2024-05-13 21:25   ` Question about mmc_blk_issue_flush() failure and recovery in Linux kernel Liming Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=579d5e7a-0745-4598-9d1d-ac951992a549@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=limings@nvidia.com \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).