From: Frank Lee <tiny.windzz@gmail.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Frank Lee <frank@allwinnertech.com>,
chaotian.jing@mediatek.com, Ulf Hansson <ulf.hansson@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chen-Yu Tsai <wens@csie.org>,
rmfrfs@gmail.com, marex@denx.de, linux-mmc@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-mediatek@lists.infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq()
Date: Mon, 8 Jun 2020 20:54:51 +0800 [thread overview]
Message-ID: <CAEExFWuoHhLqt4aukmP30SSXmwnmYuRq2t5HWKUBvreeABg=XQ@mail.gmail.com> (raw)
In-Reply-To: <20200605151810.vmgnnzp7cadfwsu5@gilmour.lan>
On Fri, Jun 5, 2020 at 11:18 PM Maxime Ripard <maxime@cerno.tech> wrote:
>
> Hi,
>
> On Fri, Jun 05, 2020 at 08:55:44PM +0800, Frank Lee wrote:
> > From: Yangtao Li <tiny.windzz@gmail.com>
> >
> > Using %px to show the actual address in sunxi_mmc_irq()
> > to help us to debug issue.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > Signed-off-by: Frank Lee <frank@allwinnertech.com>
>
> I'm fairly sure this hash is on purpose, and both the commit log of the
> %px introduction (ad67b74d2469) and the checkpatch message are pretty
> explicit about it.
>
> What issue were you trying to solve here?
There doesn't seem to be a strong requirement to force this to be printed out,
I just think that ____ptrval____ is very unpleasant.
Or delete %p directly?
Yangtao
next prev parent reply other threads:[~2020-06-08 12:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 12:55 [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq() Frank Lee
2020-06-05 12:55 ` [PATCH 2/2] mmc: mediatek: do not hide address in msdc_request_timeout() Frank Lee
2020-06-05 15:18 ` [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq() Maxime Ripard
2020-06-08 12:54 ` Frank Lee [this message]
2020-06-09 16:04 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEExFWuoHhLqt4aukmP30SSXmwnmYuRq2t5HWKUBvreeABg=XQ@mail.gmail.com' \
--to=tiny.windzz@gmail.com \
--cc=chaotian.jing@mediatek.com \
--cc=frank@allwinnertech.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=marex@denx.de \
--cc=matthias.bgg@gmail.com \
--cc=maxime@cerno.tech \
--cc=rmfrfs@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).