From: Christoph Hellwig <hch@infradead.org>
To: Christian L?hle <CLoehle@hyperstone.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Avri Altman <Avri.Altman@wdc.com>
Subject: Re: [PATCH] mmc: block: Differentiate busy and non-TRAN state
Date: Fri, 2 Jul 2021 08:43:40 +0100 [thread overview]
Message-ID: <YN7DrIxI2QSDhoy4@infradead.org> (raw)
In-Reply-To: <CWXP265MB268049D9AB181062DA7F6DDBC4009@CWXP265MB2680.GBRP265.PROD.OUTLOOK.COM>
> + /*
> + * Cards will never return to TRAN after completing
> + * identification commands or MMC_SEND_STATUS if they are not selected.
> + */
> + return !(cmd->opcode == MMC_GO_IDLE_STATE
> + || cmd->opcode == MMC_SEND_OP_COND
> + || cmd->opcode == MMC_ALL_SEND_CID
> + || cmd->opcode == MMC_SET_RELATIVE_ADDR
> + || cmd->opcode == MMC_SET_DSR
> + || cmd->opcode == MMC_SLEEP_AWAKE
> + || cmd->opcode == MMC_SELECT_CARD
> + || cmd->opcode == MMC_SEND_CSD
> + || cmd->opcode == MMC_SEND_CID
> + || cmd->opcode == MMC_SEND_STATUS
> + || cmd->opcode == MMC_GO_INACTIVE_STATE
> + || cmd->opcode == MMC_APP_CMD);
This is not the normal kernel style, which puts operators at the end
of the line. And while a little more verbose I think a switch statement
would be a lot more readable here:
switch (cmd->opcode) {
case MMC_GO_IDLE_STATE:
case MMC_SEND_OP_COND:
case MMC_ALL_SEND_CID:
case MMC_SET_RELATIVE_ADDR:
case MMC_SET_DSR:
case MMC_SLEEP_AWAKE:
case MMC_SELECT_CARD:
case MMC_SEND_CSD:
case MMC_SEND_CID:
case MMC_SEND_STATUS:
case MMC_GO_INACTIVE_STATE:
case MMC_APP_CMD:
return false;
default:
return true;
}
next prev parent reply other threads:[~2021-07-02 7:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 9:43 [PATCH] mmc: block: Differentiate busy and non-TRAN state Christian Löhle
2021-07-02 7:43 ` Christoph Hellwig [this message]
2021-07-06 8:20 ` Christian Löhle
2021-07-06 8:40 ` Ulf Hansson
2021-07-06 9:09 ` Christian Löhle
2021-07-06 9:34 ` Ulf Hansson
2021-07-07 6:49 ` Avri Altman
2021-07-07 8:27 ` [PATCHv2] mmc: block: Differentiate busy and PROG state Christian Löhle
2021-07-07 11:57 ` Ulf Hansson
2021-07-07 14:36 ` Christian Löhle
2021-08-09 15:16 ` Ulf Hansson
2021-07-07 9:01 ` [PATCH] mmc: block: Differentiate busy and non-TRAN state Christian Löhle
2021-07-07 10:16 ` Avri Altman
2021-07-07 14:42 ` Christian Löhle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN7DrIxI2QSDhoy4@infradead.org \
--to=hch@infradead.org \
--cc=Avri.Altman@wdc.com \
--cc=CLoehle@hyperstone.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).