From: Faiz Abbas <faiz_abbas@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
<devicetree@vger.kernel.org>, <ulf.hansson@linaro.org>,
<adrian.hunter@intel.com>
Subject: Re: [PATCH 1/3] dt-bindings: mmc: sdhci-am654: Update Output tap delay binding
Date: Fri, 7 Feb 2020 15:07:30 +0530 [thread overview]
Message-ID: <bff6f9d2-6713-e8c1-177e-f5d9ed5adbf1@ti.com> (raw)
In-Reply-To: <a437675a-6a18-14bd-f316-77bdd2bc1efb@ti.com>
Rob,
On 20/01/20 11:00 am, Faiz Abbas wrote:
> Hi Rob,
>
> On 15/01/20 7:20 am, Rob Herring wrote:
>> On Wed, Jan 08, 2020 at 08:39:18PM +0530, Faiz Abbas wrote:
>>> According to latest AM65x Data Manual[1], a different output tap delay
>>> value is recommended for all speed modes. Therefore, replace the
>>> ti,otap-del-sel binding with one ti,otap-del-sel- for each MMC/SD speed
>>> mode.
>>>
>>> [1] http://www.ti.com/lit/gpn/am6526
>>>
>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>>> ---
>>> .../devicetree/bindings/mmc/sdhci-am654.txt | 21 +++++++++++++++++--
>>> 1 file changed, 19 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-am654.txt b/Documentation/devicetree/bindings/mmc/sdhci-am654.txt
>>> index 50e87df47971..c6ccecb9ae5a 100644
>>> --- a/Documentation/devicetree/bindings/mmc/sdhci-am654.txt
>>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-am654.txt
>>> @@ -18,7 +18,20 @@ Required Properties:
>>> - clocks: Handles to the clock inputs.
>>> - clock-names: Tuple including "clk_xin" and "clk_ahb"
>>> - interrupts: Interrupt specifiers
>>> - - ti,otap-del-sel: Output Tap Delay select
>>> + Output tap delay for each speed mode:
>>> + - ti,otap-del-sel-legacy
>>> + - ti,otap-del-sel-mmc-hs
>>> + - ti,otap-del-sel-sd-hs
>>> + - ti,otap-del-sel-sdr12
>>> + - ti,otap-del-sel-sdr25
>>> + - ti,otap-del-sel-sdr50
>>> + - ti,otap-del-sel-sdr104
>>> + - ti,otap-del-sel-ddr50
>>> + - ti,otap-del-sel-ddr52
>>> + - ti,otap-del-sel-hs200
>>> + - ti,otap-del-sel-hs400
>>> + These bindings must be provided otherwise the driver will disable the
>>> + corresponding speed mode (i.e. all nodes must provide at least -legacy)
>>
>> Why not just extend the existing property to be an array. We already
>> have properties to enable/disable speed modes.
>>
>
> Its hard to keep track of which modes have values and which don't when
> you add an array. This scheme is just easier on anyone adding new values
> or updating old values.
>
> We already disable speed modes based on platform specific properties in
> other drivers. In sdhci-omap.c, the driver disables the corresponding
> speed mode if the corresponding pinmux and iodelay values are not populated.
>
Do you agree on above?
Thanks,
Faiz
next prev parent reply other threads:[~2020-02-07 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 15:09 [PATCH 0/3] Update phy configuration for AM65x Faiz Abbas
2020-01-08 15:09 ` [PATCH 1/3] dt-bindings: mmc: sdhci-am654: Update Output tap delay binding Faiz Abbas
2020-01-15 1:50 ` Rob Herring
2020-01-20 5:30 ` Faiz Abbas
2020-02-07 9:37 ` Faiz Abbas [this message]
2020-02-14 10:58 ` Faiz Abbas
2020-02-20 11:24 ` Faiz Abbas
2020-01-08 15:09 ` [PATCH 2/3] mmc: sdhci_am654: Update OTAPDLY writes Faiz Abbas
2020-01-20 12:31 ` Adrian Hunter
2020-01-08 15:09 ` [PATCH 3/3] mmc: sdhci_am654: Enable DLL only for some speed modes Faiz Abbas
2020-01-20 12:32 ` Adrian Hunter
2020-03-02 19:11 ` [PATCH 0/3] Update phy configuration for AM65x Faiz Abbas
2020-03-03 20:53 ` Ulf Hansson
2020-03-04 15:34 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bff6f9d2-6713-e8c1-177e-f5d9ed5adbf1@ti.com \
--to=faiz_abbas@ti.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).