From: ppvk@codeaurora.org
To: Sibi Sankar <sibis@codeaurora.org>
Cc: bjorn.andersson@linaro.org, adrian.hunter@intel.com,
robh+dt@kernel.org, ulf.hansson@linaro.org,
vbadigan@codeaurora.org, sboyd@kernel.org,
georgi.djakov@linaro.org, mka@chromium.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-mmc-owner@vger.kernel.org, rnayak@codeaurora.org,
matthias@chromium.org, linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V3 1/2] mmc: sdhci-msm: Add interconnect bandwidth scaling support
Date: Tue, 09 Jun 2020 14:00:14 +0530 [thread overview]
Message-ID: <f23dc598cbdbd59df22f29c2b77bd14c@codeaurora.org> (raw)
In-Reply-To: <8b2808215a09871bfccccb72cfa01e60@codeaurora.org>
Hi Sibi,
Thanks for the review.
On 2020-06-05 17:10, Sibi Sankar wrote:
> Hey Pradeep,
> Thanks for the patch.
>
> On 2020-06-05 15:00, Pradeep P V K wrote:
>> Interconnect bandwidth scaling support is now added as a
>> part of OPP [1]. So, make sure interconnect driver is ready
>
> can you please replace driver with paths
> instead?
>
ok. I will address this in my next patch set.
>> before handling interconnect scaling.
>>
>> This change is based on
>> [1] [Patch v8] Introduce OPP bandwidth bindings
>> (https://lkml.org/lkml/2020/5/12/493)
>>
>> [2] [Patch v3] mmc: sdhci-msm: Fix error handling
>> for dev_pm_opp_of_add_table()
>> (https://lkml.org/lkml/2020/5/5/491)
>
> sry didn't notice ^^ earlier
> you might want to place these
> comments and dependencies similar
> to the following patch.
> https://patchwork.kernel.org/patch/11573903/
>
ok. will modify in my next patch.
>>
>> Signed-off-by: Pradeep P V K <ppvk@codeaurora.org>
>> ---
>> drivers/mmc/host/sdhci-msm.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-msm.c
>> b/drivers/mmc/host/sdhci-msm.c
>> index b277dd7..a945e84 100644
>> --- a/drivers/mmc/host/sdhci-msm.c
>> +++ b/drivers/mmc/host/sdhci-msm.c
>> @@ -14,6 +14,7 @@
>> #include <linux/slab.h>
>> #include <linux/iopoll.h>
>> #include <linux/regulator/consumer.h>
>> +#include <linux/interconnect.h>
>>
>> #include "sdhci-pltfm.h"
>> #include "cqhci.h"
>> @@ -2070,6 +2071,13 @@ static int sdhci_msm_probe(struct
>> platform_device *pdev)
>> }
>> msm_host->bulk_clks[0].clk = clk;
>>
>> + /* Make sure that ICC driver is ready for interconnect bandwdith
>
> typo /s/bandwdith/bandwidth
>
>> + * scaling before registering the device for OPP.
>> + */
>
> /* Check for optional interconnect paths */
> Maybe using ^^ would suffice since
> that's what we are actually doing
>
sure. i will re-modify the comments as suggested ^^ in my next patch.
> Reviewed-by: Sibi Sankar <sibis@codeaurora.org>
>
>> + ret = dev_pm_opp_of_find_icc_paths(&pdev->dev, NULL);
>> + if (ret)
>> + goto bus_clk_disable;
>> +
>> msm_host->opp_table = dev_pm_opp_set_clkname(&pdev->dev, "core");
>> if (IS_ERR(msm_host->opp_table)) {
>> ret = PTR_ERR(msm_host->opp_table);
next prev parent reply other threads:[~2020-06-09 8:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 11:14 [PATCH V2 0/2] Add SDHC interconnect bandwidth scaling Pradeep P V K
2020-06-04 11:14 ` [PATCH V2 1/2] mmc: sdhci-msm: Add interconnect bandwidth scaling support Pradeep P V K
2020-06-04 17:09 ` Matthias Kaehlcke
2020-06-04 18:34 ` Sibi Sankar
2020-06-05 8:06 ` ppvk
2020-06-04 11:14 ` [PATCH V2 2/2] dt-bindings: mmc: sdhci-msm: Add interconnect BW scaling strings Pradeep P V K
2020-06-05 9:30 ` =?y?q?=5BPATCH=C2=A0V3=200/2=5D=20Add=20SDHC=20interconnect=20bandwidth=20scaling=20?= Pradeep P V K
2020-06-05 9:30 ` =?y?q?=5BPATCH=C2=A0V3=201/2=5D=20mmc=3A=20sdhci-msm=3A=20Add=20interconnect=20bandwidth=20scaling=20support?= Pradeep P V K
2020-06-05 11:40 ` [PATCH V3 1/2] mmc: sdhci-msm: Add interconnect bandwidth scaling support Sibi Sankar
2020-06-09 8:30 ` ppvk [this message]
2020-06-05 9:30 ` =?y?q?=5BPATCH=C2=A0V3=202/2=5D=20dt-bindings=3A=20mmc=3A=20sdhci-msm=3A=20Add=20interconnect=20BW=20scaling=20strings?= Pradeep P V K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f23dc598cbdbd59df22f29c2b77bd14c@codeaurora.org \
--to=ppvk@codeaurora.org \
--cc=adrian.hunter@intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc-owner@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias@chromium.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).