From: Alexey Gladkov <gladkov.alexey@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
linux-api@vger.kernel.org, linux-modules@vger.kernel.org,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>,
"Dmitry V. Levin" <ldv@altlinux.org>,
Michal Marek <michal.lkml@markovi.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Jessica Yu <jeyu@kernel.org>,
Lucas De Marchi <lucas.de.marchi@gmail.com>
Subject: Re: [PATCH v3] moduleparam: Save information about built-in modules in separate file
Date: Mon, 29 Apr 2019 17:35:55 +0200 [thread overview]
Message-ID: <20190429153555.GX9023@dhcp129-178.brq.redhat.com> (raw)
In-Reply-To: <CAK7LNARpeSTr=VWudDRQ8sobcPQqtqzcLm7EqyvoKFYT84Hk6Q@mail.gmail.com>
On Tue, Apr 30, 2019 at 12:08:44AM +0900, Masahiro Yamada wrote:
> > modules.builtin
> > +modules.builtin.modinfo
> >
> > #
> > # Top-level generic files
>
>
> Let me repeat the same comments as in v2
> (https://patchwork.kernel.org/patch/10888207/#22595563)
> as you ignored them.
I miss it. Sorry about that.
> > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> > index c8cf45362bd6..41ef7cb043c1 100755
> > --- a/scripts/link-vmlinux.sh
> > +++ b/scripts/link-vmlinux.sh
> > @@ -226,6 +226,10 @@ modpost_link vmlinux.o
> > # modpost vmlinux.o to check for section mismatches
> > ${MAKE} -f "${srctree}/scripts/Makefile.modpost" vmlinux.o
> >
> > +info MODINFO modules.builtin.modinfo
> > +"${OBJCOPY}" -j .modinfo -O binary vmlinux.o modules.builtin.modinfo
> > +chmod 444 modules.builtin.modinfo
>
>
> Why is this 'chmod 444' necessary?
I just wanted to show that this file will never change.
I will remove this line.
--
Rgrds, legion
prev parent reply other threads:[~2019-04-29 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 9:08 [PATCH v3] moduleparam: Save information about built-in modules in separate file Alexey Gladkov
2019-04-29 14:21 ` Jessica Yu
2019-04-29 15:08 ` Masahiro Yamada
2019-04-29 15:35 ` Alexey Gladkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429153555.GX9023@dhcp129-178.brq.redhat.com \
--to=gladkov.alexey@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=glebfm@altlinux.org \
--cc=jeyu@kernel.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=ldv@altlinux.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=michal.lkml@markovi.net \
--cc=rusty@rustcorp.com.au \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).