From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CAB3ECE58C for ; Fri, 11 Oct 2019 14:24:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 49D0021D71 for ; Fri, 11 Oct 2019 14:24:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570803893; bh=7WNbNuVGYV5eZL82IZCet7k3ExN3DOziqXTv/0qhn2w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KQ6JF+Re6tLZaiKrJAE7ejtJD1S6s/i8OBnwvUpKuDGeixhCjpSyMEsSLjmq2FGtt Uq/AcU2TBDcjewnSTeU0Sd9cMro2N6G/v35Xgi4kkdTDTTUpthvgTBRUd3MrqpSbJT t/A0oei0tOadf/PtFo6SjbhiriWSpkvkaLuDANqQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728429AbfJKOYx (ORCPT ); Fri, 11 Oct 2019 10:24:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:36588 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728394AbfJKOYw (ORCPT ); Fri, 11 Oct 2019 10:24:52 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7551E206A1; Fri, 11 Oct 2019 14:24:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570803892; bh=7WNbNuVGYV5eZL82IZCet7k3ExN3DOziqXTv/0qhn2w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qdijBbRWLgIi6ow0KgKI8n99W/Sxk++JlvicO3KdIs2F4mLiedmPi/GRUUrHaJOcu eytioo23qnU7+M3W0YKpmGoUCBhArQ86ryXhkkycOc00lSZ/fKvHpfYA++KrlmFw7g CbAM7stPzlFmPfZthvSD9N+LsTYxiErkF1Gu9gHU= Date: Fri, 11 Oct 2019 15:24:47 +0100 From: Will Deacon To: Matthias Maennich Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Jessica Yu , Masahiro Yamada , Martijn Coenen , Lucas De Marchi , Shaun Ruffell , Greg Kroah-Hartman , linux-kbuild@vger.kernel.org, linux-modules@vger.kernel.org Subject: Re: [PATCH 3/4] symbol namespaces: revert to previous __ksymtab name scheme Message-ID: <20191011142446.nyxhlhsfzcroipnf@willie-the-truck> References: <20191010151443.7399-1-maennich@google.com> <20191010151443.7399-4-maennich@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191010151443.7399-4-maennich@google.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: owner-linux-modules@vger.kernel.org Precedence: bulk List-ID: On Thu, Oct 10, 2019 at 04:14:42PM +0100, Matthias Maennich wrote: > The introduction Symbol Namespaces changed the naming schema of the Missing "of" ? > __ksymtab entries from __kysmtab__symbol to __ksymtab_NAMESPACE.symbol. > > That caused some breakages in tools that depend on the name layout in > either the binaries(vmlinux,*.ko) or in System.map. E.g. kmod's depmod > would not be able to read System.map without a patch to support symbol > namespaces. A warning reported by depmod for namespaced symbols would > look like > > depmod: WARNING: [...]/uas.ko needs unknown symbol usb_stor_adjust_quirks > > In order to address this issue, revert to the original naming scheme and > rather read the __kstrtabns_ entries and their corresponding > values from __ksymtab_strings to update the namespace values for > symbols. After having read all symbols and handled them in > handle_modversions(), the symbols are created. In a second pass, read > the __kstrtabns_ entries and update the namespaces accordingly. > > Suggested-by: Jessica Yu > Fixes: 8651ec01daed ("module: add support for symbol namespaces.") > Signed-off-by: Matthias Maennich > --- > include/linux/export.h | 13 +++++-------- > scripts/mod/modpost.c | 33 ++++++++++++++++++--------------- > scripts/mod/modpost.h | 1 + > 3 files changed, 24 insertions(+), 23 deletions(-) Patch looks fine, and it would be good to have this fixed in 5.4: Acked-by: Will Deacon Will