From: Lucas De Marchi <lucas.de.marchi@gmail.com>
To: linux-modules <linux-modules@vger.kernel.org>
Cc: Jorge Lucangeli Obes <jorgelo@google.com>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH] libkmod: reset was_space on second pass
Date: Mon, 27 Jan 2020 10:46:02 -0300 [thread overview]
Message-ID: <CAKi4VAJjA_G5KZ2Z6uAMKcp-38mF3PfAsfM1MvLQcKuDO7vWsA@mail.gmail.com> (raw)
In-Reply-To: <20200120192210.6370-1-lucas.de.marchi@gmail.com>
On Mon, Jan 20, 2020 at 4:22 PM Lucas De Marchi
<lucas.de.marchi@gmail.com> wrote:
>
> From: Lucas De Marchi <lucas.demarchi@intel.com>
>
> The softdep config parser uses a 2-pass approach to use a single
> allocation for all the softdep struct. However "was_space" variable
> isn't reset between them. This can lead to a buffer overflow.
>
> Reported-by: Jorge Lucangeli Obes <jorgelo@google.com>
> Link: https://lore.kernel.org/linux-modules/CAKYuF5QhGCPCazHQjN-=kFc5kHs7Ok8WqmmGLo31CiOEN8TYdA@mail.gmail.com
> ---
Applied,
Lucas De Marchi
> libkmod/libkmod-config.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libkmod/libkmod-config.c b/libkmod/libkmod-config.c
> index aaac0a1..7b62367 100644
> --- a/libkmod/libkmod-config.c
> +++ b/libkmod/libkmod-config.c
> @@ -335,6 +335,7 @@ static int kmod_config_add_softdep(struct kmod_config *config,
> n_pre = 0;
> n_post = 0;
> mode = S_NONE;
> + was_space = false;
> for (p = s = line; ; s++) {
> size_t plen;
>
> --
> 2.24.1
>
--
Lucas De Marchi
next prev parent reply other threads:[~2020-01-27 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 19:22 [PATCH] libkmod: reset was_space on second pass Lucas De Marchi
2020-01-27 13:46 ` Lucas De Marchi [this message]
2020-01-28 15:03 ` Jorge Lucangeli Obes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKi4VAJjA_G5KZ2Z6uAMKcp-38mF3PfAsfM1MvLQcKuDO7vWsA@mail.gmail.com \
--to=lucas.de.marchi@gmail.com \
--cc=jorgelo@google.com \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).