linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.de.marchi@gmail.com>
To: Mian Yousaf Kaukab <yousaf.kaukab@suse.com>
Cc: linux-modules <linux-modules@vger.kernel.org>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	bjorn.andersson@linaro.org, afaerber@suse.de
Subject: Re: [PATCH v1 1/2] testsuite: depmod: add module dependency outside cyclic chain
Date: Tue, 8 Nov 2016 22:29:31 -0200	[thread overview]
Message-ID: <CAKi4VAJxFd8KpJ3DsGYOxuayyEj60oa3_vsLC_oz+DOWLnr6FA@mail.gmail.com> (raw)
In-Reply-To: <1478623550-18716-1-git-send-email-yousaf.kaukab@suse.com>

On Tue, Nov 8, 2016 at 2:45 PM, Mian Yousaf Kaukab
<yousaf.kaukab@suse.com> wrote:
> Check that depmod do not report modules outside cyclic chain
>
> Two modules f and g are added which do not have any dependency.
> modules a and b are made dependent on f and g.
>
> Signed-off-by: Mian Yousaf Kaukab <yousaf.kaukab@suse.com>
> ---
> Here is the output of loop dependency check test after adding this
> patch:
>
> ESTSUITE: ERR: wrong:
> depmod: ERROR: Found 7 modules in dependency cycles!
> depmod: ERROR: Cycle detected: mod_loop_d -> mod_loop_e -> mod_loop_d
> depmod: ERROR: Cycle detected: mod_loop_b -> mod_loop_c -> mod_loop_a -> mod_loop_b
> depmod: ERROR: Cycle detected: mod_loop_b -> mod_loop_c -> mod_loop_a -> mod_loop_g
> depmod: ERROR: Cycle detected: mod_loop_b -> mod_loop_c -> mod_loop_a -> mod_loop_f
>
> Buffer overflow occurs in the loop when last two lines are printed.
> 43 bytes buffer is allocated and 53 bytes are used.


Great!

I found this last part of the message very useful to be in the commit
message, so I moved it there.

Thanks,
Applied

Lucas De Marchi

-- 
Lucas De Marchi

      parent reply	other threads:[~2016-11-09  0:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08 16:45 [PATCH v1 1/2] testsuite: depmod: add module dependency outside cyclic chain Mian Yousaf Kaukab
2016-11-08 16:45 ` [PATCH v1 2/2] depmod: ignore related modules in depmod_report_cycles Mian Yousaf Kaukab
2016-11-09  0:40   ` Lucas De Marchi
2016-11-09  2:59     ` Yauheni Kaliuta
2016-11-09  9:17       ` Mian Yousaf Kaukab
2016-11-09 11:23         ` Yauheni Kaliuta
2016-11-11 11:43         ` [PATCH RFC 0/3] Proposal for cycles handling Yauheni Kaliuta
2016-11-11 11:43           ` [PATCH RFC 2/3] libkmod: list: export list handling functions Yauheni Kaliuta
2017-02-13  8:05             ` Lucas De Marchi
2017-02-20 14:22               ` Yauheni Kaliuta
2017-02-22  5:26                 ` Lucas De Marchi
2017-02-22  9:41                   ` [PATCH v3 0/2] Proposal for cycles handling Yauheni Kaliuta
2017-02-22  9:41                     ` [PATCH v3 1/2] testsuite: depmod: check netsted loops reporting Yauheni Kaliuta
2017-02-22  9:41                     ` [PATCH v3 2/2] depmod: handle nested loops Yauheni Kaliuta
2017-02-23 22:30                       ` Lucas De Marchi
2016-11-11 11:43           ` [PATCH RFC 3/3] " Yauheni Kaliuta
2017-02-13  8:30             ` Lucas De Marchi
2017-02-20 14:16               ` Yauheni Kaliuta
2017-02-13  8:16           ` [PATCH RFC 0/3] Proposal for cycles handling Lucas De Marchi
2017-02-13  9:56             ` Yauheni Kaliuta
2017-02-13  8:32           ` Lucas De Marchi
2017-02-20 14:18             ` [PATCH RFC v2 0/2] " Yauheni Kaliuta
2017-02-20 14:18               ` [PATCH RFC v2 1/2] testsuite: depmod: check netsted loops reporting Yauheni Kaliuta
2017-02-20 14:19               ` [PATCH RFC v2 2/2] depmod: handle nested loops Yauheni Kaliuta
2016-11-09  0:29 ` Lucas De Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKi4VAJxFd8KpJ3DsGYOxuayyEj60oa3_vsLC_oz+DOWLnr6FA@mail.gmail.com \
    --to=lucas.de.marchi@gmail.com \
    --cc=afaerber@suse.de \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=lucas.demarchi@intel.com \
    --cc=yousaf.kaukab@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).