From: Lucas De Marchi <lucas.de.marchi@gmail.com>
To: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
linux-modules <linux-modules@vger.kernel.org>
Subject: Re: [PATCH RFC 0/3] depmod: implement external directories support
Date: Tue, 9 May 2017 00:51:43 -0700 [thread overview]
Message-ID: <CAKi4VALJgW=RbpCT4kfix9sACzzz68=LZ-FhUUORXxHMcTA__g@mail.gmail.com> (raw)
In-Reply-To: <xunyshmagsw1.fsf@redhat.com>
On Sat, Mar 18, 2017 at 2:46 PM, Yauheni Kaliuta
<yauheni.kaliuta@redhat.com> wrote:
> Hi, Lucas!
>
> Any feedback on that?
I gave it a quick look and it looks good to me. I applied the second patch.
For first patch would be good to use scratchbuf
For this one... I miss some tests in the testsuite to be confident
this a) is working as expected
and b) isn't break the current behavior.
Sorry for the delay.
Lucas De Marchi
next prev parent reply other threads:[~2017-05-09 7:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 15:23 [PATCH RFC 0/3] depmod: implement external directories support Yauheni Kaliuta
2016-11-23 15:23 ` [PATCH RFC 1/3] depmod: create depmod dir independent search function Yauheni Kaliuta
2017-05-09 6:56 ` Lucas De Marchi
2016-11-23 15:23 ` [PATCH RFC 2/3] depmod: search key: move builtin detection under the add function Yauheni Kaliuta
2017-05-09 7:04 ` Lucas De Marchi
2016-11-23 15:23 ` [PATCH RFC 3/3] depmod: implement external directories support Yauheni Kaliuta
2017-03-18 21:46 ` [PATCH RFC 0/3] " Yauheni Kaliuta
2017-05-09 7:51 ` Lucas De Marchi [this message]
2017-05-09 8:50 ` Yauheni Kaliuta
2017-05-09 19:09 ` [PATCHv2 0/4] " Yauheni Kaliuta
2017-05-09 19:09 ` [PATCHv2 1/4] depmod: create depmod dir independent search function Yauheni Kaliuta
2017-06-02 2:18 ` Lucas De Marchi
2017-05-09 19:09 ` [PATCHv2 2/4] depmod: rewrite depmod modules search with scratchbuf Yauheni Kaliuta
2017-06-02 3:23 ` Lucas De Marchi
2017-05-09 19:09 ` [PATCHv2 3/4] depmod: implement external directories support Yauheni Kaliuta
2017-06-02 3:30 ` Lucas De Marchi
2017-05-09 19:09 ` [PATCHv2 4/4] testsuite: add tests for external directory support Yauheni Kaliuta
2017-06-02 4:03 ` Lucas De Marchi
2017-06-02 4:05 ` [PATCHv2 0/4] depmod: implement external directories support Lucas De Marchi
2017-06-20 9:11 ` Yauheni Kaliuta
2017-07-19 18:07 ` Lucas De Marchi
2017-07-19 18:57 ` Yauheni Kaliuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKi4VALJgW=RbpCT4kfix9sACzzz68=LZ-FhUUORXxHMcTA__g@mail.gmail.com' \
--to=lucas.de.marchi@gmail.com \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=yauheni.kaliuta@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).