From: Paul Cercueil <paul@crapouillou.net>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Richard Weinberger <richard@nod.at>,
Harvey Hunt <harveyhuntnexus@gmail.com>,
linux-mtd@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH] mtd: rawnand: ingenic: Convert the driver to exec_op()
Date: Tue, 19 May 2020 17:10:12 +0200 [thread overview]
Message-ID: <0H3LAQ.G5DAMEP9GDQC2@crapouillou.net> (raw)
In-Reply-To: <20200519170130.77543c8e@collabora.com>
Le mar. 19 mai 2020 à 17:01, Boris Brezillon
<boris.brezillon@collabora.com> a écrit :
> On Tue, 19 May 2020 16:52:27 +0200
> Paul Cercueil <paul@crapouillou.net> wrote:
>
>> Hi Boris,
>>
>> Le lun. 18 mai 2020 à 21:24, Boris Brezillon
>> <boris.brezillon@collabora.com> a écrit :
>> > On Mon, 18 May 2020 19:50:04 +0200
>> > Paul Cercueil <paul@crapouillou.net> wrote:
>> >
>> >> Hi Boris,
>> >>
>> >> Le lun. 18 mai 2020 à 18:56, Boris Brezillon
>> >> <boris.brezillon@collabora.com> a écrit :
>> >> > Let's convert the driver to exec_op() to have one less driver
>> >> relying
>> >> > on the legacy interface.
>> >>
>> >> Great work, thanks for that.
>> >>
>> >> However it does not work :( nand_scan() returns error -145.
>> >
>> > Looks like the R/B signal is inverted. Can you try with the
>> > following diff applied?
>>
>> Still doesn't work properly. I get -ENODEV in nand_detect(), at the
>> "second ID read did not match..." pr_info().
>>
>> The R/B signal doesn't seem to be the primary cause, if I use
>> nand_soft_waitrdy() it doesn't work any better.
>
> Well, it does solve the ETIMEDOUT issue, so we're one step further
> ;-).
> Can you print the returned ID?
It reads 00/00, so it doesn't seem to be able to read any data.
>>
>> One thing I noticed that jz4780_nemc_assert() is called with
>> assert=true unconditionally, while before it was called with (ctrl &
>> NAND_NCE), whatever that is. Whether or not that's a problem, I
>> have no
>> idea.
>
> Yes, we really want to assert the CE signal unconditionally here, but
> maybe we should add a delay after asserting it/before de-asserting it.
I added some udelay() here and there, unfortunately it didn't change
anything.
-Paul
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-05-19 15:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 16:56 [PATCH] mtd: rawnand: ingenic: Convert the driver to exec_op() Boris Brezillon
2020-05-18 17:50 ` Paul Cercueil
2020-05-18 19:24 ` Boris Brezillon
2020-05-18 19:35 ` Boris Brezillon
2020-05-19 15:04 ` Paul Cercueil
2020-05-19 17:28 ` Boris Brezillon
2020-05-19 21:12 ` Paul Cercueil
2020-05-19 23:13 ` Boris Brezillon
2020-05-19 14:52 ` Paul Cercueil
2020-05-19 15:01 ` Boris Brezillon
2020-05-19 15:10 ` Paul Cercueil [this message]
2020-05-19 17:35 ` Boris Brezillon
2020-05-19 21:15 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0H3LAQ.G5DAMEP9GDQC2@crapouillou.net \
--to=paul@crapouillou.net \
--cc=boris.brezillon@collabora.com \
--cc=harveyhuntnexus@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).