Hi Randy, thanks for the patch. On Thu, Nov 01, 2018 at 04:38:30PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > arch/sh/boards/mach-kfr2r09/setup.c does not need to #include > , and doing so causes a build warning, so drop > that header file. > > In file included from ../arch/sh/boards/mach-kfr2r09/setup.c:28: > ../include/linux/mtd/onenand.h:225:12: warning: 'struct mtd_oob_ops' declared inside parameter list will not be visible outside of this definition or declaration > struct mtd_oob_ops *ops); > > Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera driver") Not sure if this is worth pointing out, but this commit only resorts headers. The one introducing the warning is actually 33893d7aa. I felt like reporting this, as introducing a "Fixes" line for that commit too would help backporting maybe? In any case: Acked-by: Jacopo Mondi Thanks j > > Reported-by: Geert Uytterhoeven > Suggested-by: Miquel Raynal > Signed-off-by: Randy Dunlap > Reviewed-by: Miquel Raynal > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: Jacopo Mondi > Cc: Magnus Damm > Cc: linux-mtd@lists.infradead.org > Cc: linux-sh@vger.kernel.org > --- > arch/sh/boards/mach-kfr2r09/setup.c | 1 - > 1 file changed, 1 deletion(-) > > --- linux-next-20181101.orig/arch/sh/boards/mach-kfr2r09/setup.c > +++ linux-next-20181101/arch/sh/boards/mach-kfr2r09/setup.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > #include > #include > #include > >