From: Boris Brezillon <bbrezillon@kernel.org>
To: Tokunori Ikegami <ikegami_to@yahoo.co.jp>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
linux-mtd@lists.infradead.org, Fabio Bettoni <fbettoni@gmail.com>,
Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Subject: Re: [PATCH v4 02/11] mtd: cfi_cmdset_0002: Remove chip_ready() from do_write_buffer()
Date: Mon, 4 Feb 2019 19:05:43 +0100 [thread overview]
Message-ID: <20190204190534.456d7bb4@bbrezillon> (raw)
In-Reply-To: <20190204173550.29703-3-ikegami_to@yahoo.co.jp>
On Tue, 5 Feb 2019 02:35:41 +0900
Tokunori Ikegami <ikegami_to@yahoo.co.jp> wrote:
> It is enough to use chip_good() only so chip_ready() is not necessary.
> Since chip_good() is doing the same check chip_ready() is doing plus an extra
> check to make sure we end up with the data we wrote.
>
> For this change the order to check timeout also will be changed at same time.
> The order is not a hard requirement, it's just better to avoid the case where
> the data update happens just after the timeout has expired.
>
> Signed-off-by: Tokunori Ikegami <ikegami_to@yahoo.co.jp>
This patch actually fixes a bug (as reported in the other thread), so
please add Fixes and Cc-stable tags and explain why it might cause
an infinite loop in the commit message.
> Cc: Fabio Bettoni <fbettoni@gmail.com>
> Co: Hauke Mehrtens <hauke@hauke-m.de>
> Co: Koen Vandeputte <koen.vandeputte@ncentric.com>
> Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: linux-mtd@lists.infradead.org
> ---
> Changes since v3:
> - Update the commit message for the comment.
> - Change the email address of Tokunori Ikegami to ikegami_to@yahoo.co.jp.
>
> Changes since v2:
> - None.
>
> Changes since v1:
> - None.
>
> drivers/mtd/chips/cfi_cmdset_0002.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
> index 91a491b..ca9d5fa 100755
> --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> @@ -1878,14 +1878,14 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip,
> continue;
> }
>
> - if (time_after(jiffies, timeo) && !chip_ready(map, adr))
> - break;
> -
> if (chip_good(map, adr, datum)) {
> xip_enable(map, chip, adr);
> goto op_done;
> }
>
> + if (time_after(jiffies, timeo))
> + break;
> +
> /* Latency issues. Drop the lock, wait a while and retry */
> UDELAY(map, chip, adr, 1);
> }
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-02-04 18:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 17:35 [PATCH v4 00/11] mtd: cfi_cmdset_0002: Fix flash write issue for OpenWrt Project Tokunori Ikegami
2019-02-04 17:35 ` [PATCH v4 01/11] mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword() Tokunori Ikegami
2019-02-04 17:35 ` [PATCH v4 02/11] mtd: cfi_cmdset_0002: Remove chip_ready() from do_write_buffer() Tokunori Ikegami
2019-02-04 18:05 ` Boris Brezillon [this message]
2019-02-04 18:27 ` Tokunori Ikegami
2019-02-05 13:15 ` Tokunori Ikegami
2019-02-04 17:35 ` [PATCH v4 03/11] mtd: cfi_cmdset_0002: Remove goto statement " Tokunori Ikegami
2019-02-04 17:35 ` [PATCH v4 04/11] mtd: cfi_cmdset_0002: Call xip_enable() once only in do_write_buffer() Tokunori Ikegami
2019-02-04 17:35 ` [PATCH v4 05/11] mtd: cfi_cmdset_0002: Split do_write_oneword() to reduce function size Tokunori Ikegami
2019-02-04 17:35 ` [PATCH v4 06/11] mtd: cfi_cmdset_0002: Split do_write_oneword() op_done goto statement Tokunori Ikegami
2019-02-04 17:35 ` [PATCH v4 07/11] mtd: cfi_cmdset_0002: Remove op_done goto statement from do_write_oneword() Tokunori Ikegami
2019-02-04 17:35 ` [PATCH v4 08/11] mtd: cfi_cmdset_0002: Remove retry " Tokunori Ikegami
2019-02-04 17:35 ` [PATCH v4 09/11] mtd: cfi_cmdset_0002: Split write-to-buffer-reset sequence Tokunori Ikegami
2019-02-04 17:35 ` [PATCH v4 10/11] mtd: cfi_cmdset_0002: Split to wait write buffer to check if completed Tokunori Ikegami
2019-02-04 17:35 ` [PATCH v4 11/11] mtd: cfi_cmdset_0002: Split do_write_oneword() to reduce exit paths Tokunori Ikegami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204190534.456d7bb4@bbrezillon \
--to=bbrezillon@kernel.org \
--cc=Joakim.Tjernlund@infinera.com \
--cc=boris.brezillon@free-electrons.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=fbettoni@gmail.com \
--cc=ikegami_to@yahoo.co.jp \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).