From: Rob Herring <robh@kernel.org>
To: Piotr Sroka <piotrs@cadence.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org,
BrianNorris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2 2/2] dt-bindings: nand: Add Cadence NAND controller driver
Date: Fri, 22 Feb 2019 14:40:52 -0600 [thread overview]
Message-ID: <20190222204052.GA17855@bogus> (raw)
In-Reply-To: <20190219161920.26602-1-piotrs@cadence.com>
On Tue, Feb 19, 2019 at 04:19:20PM +0000, Piotr Sroka wrote:
> Signed-off-by: Piotr Sroka <piotrs@cadence.com>
> ---
> Changes for v2:
> - remove chip dependends parameters from dts bindings
> - add names for register ranges in dts bindings
> - add generic bindings to describe NAND chip representation
> under the NAND controller node
> ---
> .../bindings/mtd/cadence-nand-controller.txt | 48 ++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/cadence-nand-controller.txt
>
> diff --git a/Documentation/devicetree/bindings/mtd/cadence-nand-controller.txt b/Documentation/devicetree/bindings/mtd/cadence-nand-controller.txt
> new file mode 100644
> index 000000000000..3d9b4decae24
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/cadence-nand-controller.txt
> @@ -0,0 +1,48 @@
> +* Cadence NAND controller
> +
> +Required properties:
> + - compatible : "cdns,hpnfc"
Only one version of IP or is that discoverable?
> + - reg : Contains two entries, each of which is a tuple consisting of a
> + physical address and length. The first entry is the address and
> + length of the controller register set. The second entry is the
> + address and length of the Slave DMA data port.
> + - reg-names: should contain "cadence_reg" and "cadence_sdma"
'cadence_' part is pointless.
> + - interrupts : The interrupt number.
> + - clocks: phandle of the controller core clock (nf_clk).
> + - Children nodes represent the available NAND chips.
Need a blank line and remove the '-' as it's not a property.
> +
> +Required properties of NAND chips:
> + - reg: shall contain the native Chip Select ids from 0 to max supported by
> + the cadence nand flash controller
> +
> +Optional properties:
For child nodes? If not move before child nodes.
> + - dmas: shall reference DMA channel associated to the NAND controller
> + - cdns,board-delay : Estimated Board delay. The value includes the total
> + round trip delay for the signals and is used for deciding on values
> + associated with data read capture. The example formula for SDR mode is
> + the following:
> + board_delay = RE#PAD_delay + PCB trace to device + PCB trace from device
> + + DQ PAD delay
Units? Use unit suffix as defined in property-units.txt.
> +
> +See Documentation/devicetree/bindings/mtd/nand.txt for more details on
> +generic bindings.
> +
> +Example:
> +
> +nand_controller: nand-controller @60000000 {
space ^
> + compatible = "cdns,hpnfc";
> + reg = <0x60000000 0x10000>, <0x80000000 0x10000>;
> + reg-names = "cadence_reg", "cadence_sdma";
> + clocks = <&nf_clk>;
> + cdns,board-delay = <4830>;
> + interrupts = <2 0>;
> + nand@0 {
> + reg = <0>;
> + label = "nand-1";
> + };
> + nand@1 {
> + reg = <1>;
> + label = "nand-2";
> + };
> +
> +};
> --
> 2.15.0
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-02-22 20:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 16:14 [PATCH v2 0/2] mtd: nand: Add Cadence NAND controller driver Piotr Sroka
2019-02-19 16:18 ` [PATCH v2 1/2] " Piotr Sroka
2019-03-05 18:09 ` Miquel Raynal
2019-03-21 9:33 ` Piotr Sroka
2019-05-12 12:24 ` Miquel Raynal
2019-06-06 15:19 ` Piotr Sroka
2019-06-27 16:15 ` Miquel Raynal
2019-07-01 9:51 ` Piotr Sroka
2019-07-01 10:04 ` Miquel Raynal
2019-07-01 10:21 ` Piotr Sroka
2019-02-19 16:19 ` [PATCH v2 2/2] dt-bindings: " Piotr Sroka
2019-02-22 20:40 ` Rob Herring [this message]
2019-06-07 16:08 ` Piotr Sroka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222204052.GA17855@bogus \
--to=robh@kernel.org \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=piotrs@cadence.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).