From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: Richard Weinberger <richard.weinberger@gmail.com>,
linux-mtd@lists.infradead.org,
Boris Brezillon <bbrezillon@kernel.org>
Subject: Re: i.MX28 nand driver broken in Linux 4.18
Date: Mon, 1 Apr 2019 11:23:49 +0200 [thread overview]
Message-ID: <20190401112349.60bcf6d7@xps13> (raw)
In-Reply-To: <1c876ede-7321-a7c3-a366-86ca1dafce20@grandegger.com>
Hi Wolfgang,
Wolfgang Grandegger <wg@grandegger.com> wrote on Sat, 23 Mar 2019
20:55:19 +0100:
> Hello Miquel,
>
> Am 06.03.19 um 14:59 schrieb Miquel Raynal:
> > Hi Wolfgang,
> >
> > Wolfgang Grandegger <wg@grandegger.com> wrote on Tue, 5 Mar 2019
> > 15:52:52 +0100:
> >
> >> Hello,
> >>
> >> I will bisect the problem next week when I have access to the
> >> hardware... more soon...
> >>
> >
> > Great, thanks.
>
> Here is the result of git bisection:
>
> wolf@bernex:~/git/linux$ git bisect good
> 76e1a0086a0c3276b384f77905345e0fcc886fdd is the first bad commit
> commit 76e1a0086a0c3276b384f77905345e0fcc886fdd
> Author: Miquel Raynal <miquel.raynal@bootlin.com>
> Date: Fri Mar 2 15:38:39 2018 +0100
>
> mtd: rawnand: gpmi: support ->setup_data_interface()
>
> Until now the GPMI driver had its own timings logic while the core
> already handles that and request the NAND controller drivers to support
> the ->setup_data_interface() hook. Implement that hook by reusing the
> already existing function. No real glue is necessary between core timing
> delays and GPMI registers because the driver already translates the
> ONFI timing modes into register values.
>
> Make use of the core's tREA, tRLOH and tRHOH values that allow computing
> more precise timings for mode [0-3] and get significantly better values
> (+20% with an i.MX6 Sabre Auto board). Otherwise use the existing logic.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Tested-by: Han Xu <han.xu@nxp.com>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Thank you for the bisection, there is definitely something wrong with
this commit but it worked for me and for Han so it's quite difficult to
find out what is failing if I cannot reproduce. Could you please dump
the timing registers in both cases (working/not working) and observer if
there are odd values ? (0, too short or too big values, etc).
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-04-01 9:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 9:27 i.MX28 nand driver broken in Linux 4.18 Wolfgang Grandegger
2019-03-04 11:54 ` Miquel Raynal
2019-03-04 20:46 ` Wolfgang Grandegger
2019-03-05 14:52 ` Wolfgang Grandegger
2019-03-06 13:59 ` Miquel Raynal
2019-03-23 19:55 ` Wolfgang Grandegger
2019-04-01 9:23 ` Miquel Raynal [this message]
2019-04-01 20:08 ` Wolfgang Grandegger
2019-04-02 9:16 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401112349.60bcf6d7@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.weinberger@gmail.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).