From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] mtd: rawnand: marvell: Fix helper name in comment
Date: Thu, 18 Apr 2019 18:19:59 +0200 [thread overview]
Message-ID: <20190418181959.43a474e5@xps13> (raw)
In-Reply-To: <20190408092849.23478-1-miquel.raynal@bootlin.com>
Hello,
Miquel Raynal <miquel.raynal@bootlin.com> wrote on Mon, 8 Apr 2019
11:28:49 +0200:
> Since the migration of the driver to stop using the legacy
> ->select_chip() hook, the marvell_nfc_select_chip() helper has been
> 'renamed' to marvell_nfc_select_target(). Update a left-over reference
> to this helper in a comment in the ->resume() path.
>
> Fixes: b25251414f6e00 ("mtd: rawnand: marvell: Stop implementing ->select_chip()")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> drivers/mtd/nand/raw/marvell_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
> index d984538980e2..6796c7015d86 100644
> --- a/drivers/mtd/nand/raw/marvell_nand.c
> +++ b/drivers/mtd/nand/raw/marvell_nand.c
> @@ -2989,7 +2989,7 @@ static int __maybe_unused marvell_nfc_resume(struct device *dev)
>
> /*
> * Reset nfc->selected_chip so the next command will cause the timing
> - * registers to be restored in marvell_nfc_select_chip().
> + * registers to be restored in marvell_nfc_select_target().
> */
> nfc->selected_chip = NULL;
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
branch nand/next.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2019-04-18 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 9:28 [PATCH] mtd: rawnand: marvell: Fix helper name in comment Miquel Raynal
2019-04-14 8:49 ` Boris Brezillon
2019-04-18 16:19 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418181959.43a474e5@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).