From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Xiaolei Li <xiaolei.li@mediatek.com>,
miquel.raynal@bootlin.com, richard@nod.at
Cc: linux-mtd@lists.infradead.org,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com
Subject: Re: [PATCH v3 2/4] mtd: rawnand: mtk: Improve data sampling timing for read cycle
Date: Mon, 3 Jun 2019 10:04:46 +0200 [thread overview]
Message-ID: <20190603080446.28858-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20190507102541.34341-3-xiaolei.li@mediatek.com>
On Tue, 2019-05-07 at 10:25:39 UTC, Xiaolei Li wrote:
> Currently, we expand RE# low level time by choosing the max value
> between RE# pulse width and RE# access time, and sample data at the
> rising edge of RE#.
>
> Then, if RE# access time is bigger than RE# pulse width, the real
> read cycle time may be more than NAND SPEC required. This makes
> read performance be worse than that expected.
>
> This patch improves data sampling timing by calculating RE# low level
> time according to RE# pulse width. If RE# access time is bigger than
> RE# pulse width, then delay sampling data timing.
>
> The result of contrast test base on MT2712 evaluat board is as follow.
>
> nand: Micron MT29F16G08ADBCAH4
> nand: 2048 MiB, SLC, erase size: 256 KiB, page size: 4096, OOB size: 224
> NFI 2x clock rate: 124800000 HZ.
>
> Read speed without this patch:
> mtd_speedtest: page read speed is 14012 KiB/s
> mtd_speedtest: 2 page read speed is 14860 KiB/s
>
> Read speed with this patch:
> mtd_speedtest: page read speed is 18724 KiB/s
> mtd_speedtest: 2 page read speed is 18713 KiB/s
>
> Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com>
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-06-03 8:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 10:25 [PATCH v3 0/4] MTK NAND driver improvements and fixes Xiaolei Li
2019-05-07 10:25 ` [PATCH v3 1/4] mtd: rawnand: mtk: Correct low level time calculation of r/w cycle Xiaolei Li
2019-06-03 8:04 ` Miquel Raynal
2019-05-07 10:25 ` [PATCH v3 2/4] mtd: rawnand: mtk: Improve data sampling timing for read cycle Xiaolei Li
2019-06-03 8:04 ` Miquel Raynal [this message]
2019-05-07 10:25 ` [PATCH v3 3/4] mtd: rawnand: mtk: Add validity check for CE# pin setting Xiaolei Li
2019-06-03 8:04 ` Miquel Raynal
2019-05-07 10:25 ` [PATCH v3 4/4] mtd: rawnand: mtk: Fix wrongly assigned OOB buffer pointer issue Xiaolei Li
2019-06-03 8:04 ` Miquel Raynal
2019-05-17 1:32 ` [PATCH v3 0/4] MTK NAND driver improvements and fixes xiaolei li
2019-05-17 8:12 ` Miquel Raynal
2019-05-17 9:21 ` xiaolei li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603080446.28858-1-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=srv_heupstream@mediatek.com \
--cc=xiaolei.li@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).