From: <Tudor.Ambarus@microchip.com>
To: <richard@nod.at>, <miquel.raynal@bootlin.com>, <vigneshr@ti.com>,
<boris.brezillon@collabora.com>, <linux-mtd@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <zhuohao@chromium.org>
Cc: Tudor.Ambarus@microchip.com
Subject: [PATCH 0/2] mtd: mtdcore: add debugfs nodes for querying the flash name and id
Date: Thu, 29 Aug 2019 07:10:28 +0000 [thread overview]
Message-ID: <20190829071019.2495-1-tudor.ambarus@microchip.com> (raw)
From: Tudor Ambarus <tudor.ambarus@microchip.com>
I just rebased Zhuohao's patches and fixed some checkpatch warnings and
checks. I'll let this a little bit here for some short review, and I intend
to apply the patches later today.
For patch 1/, I fixed the following:
CHECK: multiple assignments should be avoided
#82: FILE: drivers/mtd/mtdcore.c:390:
+ root = mtd->dbg.dfs_dir = debugfs_create_dir(dev_name(dev),
WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'.
#90: FILE: drivers/mtd/mtdcore.c:398:
+ dent = debugfs_create_file("partid", S_IRUSR, root, mtd,
WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'.
#97: FILE: drivers/mtd/mtdcore.c:405:
+ dent = debugfs_create_file("partname", S_IRUSR, root, mtd,
For patch 2/, I fixed some alignment checks, and I moved the call to
spi_nor_debugfs_init() immediately after spi_nor_get_flash_info(),
because it uses some info data set there.
CHECK: Alignment should match open parenthesis
#162: FILE: drivers/mtd/spi-nor/spi-nor.c:3939:
+static void spi_nor_debugfs_init(struct spi_nor *nor,
+ const struct flash_info *info)
CHECK: Alignment should match open parenthesis
#168: FILE: drivers/mtd/spi-nor/spi-nor.c:3945:
+ mtd->dbg.partid = devm_kasprintf(nor->dev, GFP_KERNEL,
+ "spi-nor:%*phN",
Zhuohao Lee (2):
mtd: mtdcore: add debugfs nodes for querying the flash name and id
mtd: spi-nor: enable the debugfs for the partname and partid
drivers/mtd/mtdcore.c | 86 ++++++++++++++++++++++++++++++++++++++-----
drivers/mtd/spi-nor/spi-nor.c | 12 ++++++
include/linux/mtd/mtd.h | 3 ++
3 files changed, 92 insertions(+), 9 deletions(-)
--
2.9.5
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next reply other threads:[~2019-08-29 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 7:10 Tudor.Ambarus [this message]
2019-08-29 7:10 ` [PATCH 1/2] mtd: mtdcore: add debugfs nodes for querying the flash name and id Tudor.Ambarus
2019-08-29 7:10 ` [PATCH 2/2] mtd: spi-nor: enable the debugfs for the partname and partid Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829071019.2495-1-tudor.ambarus@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=boris.brezillon@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=zhuohao@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).