From: Boris Brezillon <boris.brezillon@collabora.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: spi-nor: use spi-mem dirmap API
Date: Sat, 26 Oct 2019 09:36:02 +0200 [thread overview]
Message-ID: <20191026093602.09a8f0ab@collabora.com> (raw)
In-Reply-To: <97330369-c42e-0ce3-ab1e-0f4433e6acad@cogentembedded.com>
On Fri, 25 Oct 2019 23:26:42 +0300
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:
> Make use of the spi-mem direct mapping API to let advanced controllers
> optimize read/write operations when they support direct mapping.
>
> Based on the original patch by Boris Brezillon <boris.brezillon@bootlin.com>.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> This patch is against the 'spi-nor/next' branch of the MTD 'linux.git' repo.
>
> drivers/mtd/spi-nor/spi-nor.c | 79 ++++++++++++++++++++++++++++++++++++++++++
> include/linux/mtd/spi-nor.h | 5 ++
> 2 files changed, 84 insertions(+)
>
> Index: linux/drivers/mtd/spi-nor/spi-nor.c
> ===================================================================
> --- linux.orig/drivers/mtd/spi-nor/spi-nor.c
> +++ linux/drivers/mtd/spi-nor/spi-nor.c
> @@ -2562,6 +2562,14 @@ static int spi_nor_read(struct mtd_info
> if (ret)
> return ret;
>
> + if (nor->dirmap.rdesc) {
> + ret = spi_mem_dirmap_read(nor->dirmap.rdesc, from, len, buf);
This spi_mem_dirmap_read() call should be moved to
spi_nor_spimem_read_data().
> + if (ret < 0)
> + goto read_err;
> + *retlen += ret;
> + goto done;
> + }
> +
> while (len) {
> loff_t addr = from;
>
> @@ -2582,6 +2590,7 @@ static int spi_nor_read(struct mtd_info
> from += ret;
> len -= ret;
> }
> +done:
> ret = 0;
>
> read_err:
> @@ -2686,6 +2695,14 @@ static int spi_nor_write(struct mtd_info
> if (ret)
> return ret;
>
> + if (nor->dirmap.wdesc) {
> + ret = spi_mem_dirmap_write(nor->dirmap.wdesc, to, len, buf);
Same here, this should be moved to spi_nor_spimem_write_data(). BTW, I
wonder how this can work since write_enable() is called in the below for
loop (which you skip). Is your SPI controller sending the WE cmd
automatically?
> + if (ret < 0)
> + goto write_err;
> + *retlen += ret;
> + goto done;
> + }
> +
> for (i = 0; i < len; ) {
> ssize_t written;
> loff_t addr = to + i;
> @@ -2723,6 +2740,8 @@ static int spi_nor_write(struct mtd_info
> *retlen += written;
> i += written;
> }
> +done:
> + ret = 0;
>
> write_err:
> spi_nor_unlock_and_unprep(nor, SPI_NOR_OPS_WRITE);
> @@ -4991,6 +5010,58 @@ int spi_nor_scan(struct spi_nor *nor, co
> }
> EXPORT_SYMBOL_GPL(spi_nor_scan);
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-10-26 7:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 17:49 [PATCH 0/2] Untangle Spansion S25F{L|S}512S chip IDs Sergei Shtylyov
2019-01-16 17:51 ` [PATCH 1/2] mtd: spi-nor: add Spansion S25FS512S ID Sergei Shtylyov
2019-01-22 10:18 ` Tudor.Ambarus
2019-01-24 11:55 ` [1/2] " Boris Brezillon
2019-01-16 17:53 ` [PATCH 2/2] mtd: spi-nor: refine Spansion S25FL512S ID Sergei Shtylyov
2019-01-22 10:18 ` Tudor.Ambarus
2019-01-24 11:55 ` [2/2] " Boris Brezillon
2019-03-05 14:05 ` [PATCH 2/2] " Geert Uytterhoeven
2019-03-06 10:59 ` Tudor.Ambarus
2019-03-06 11:28 ` Tudor.Ambarus
2019-03-12 11:02 ` Geert Uytterhoeven
2019-01-21 8:28 ` [PATCH 0/2] Untangle Spansion S25F{L|S}512S chip IDs Tudor.Ambarus
2019-01-21 17:40 ` Sergei Shtylyov
2019-05-31 18:31 ` [PATCH v4] mtd: devices: m25p80: Use the spi-mem dirmap API Sergei Shtylyov
2019-06-18 4:30 ` Vignesh Raghavendra
2019-07-03 20:26 ` [PATCH] mtd: chips: gen_probe: kill useless initializer in mtd_do_chip_probe() Sergei Shtylyov
2019-09-17 4:24 ` Vignesh Raghavendra
2019-09-17 19:28 ` [PATCH] mtd: cfi_util: use DIV_ROUND_UP() in cfi_udelay() Sergei Shtylyov
2019-09-17 19:43 ` Geert Uytterhoeven
2019-09-17 19:53 ` Sergei Shtylyov
2019-09-17 21:23 ` Geert Uytterhoeven
2019-09-18 5:45 ` Vignesh Raghavendra
2019-09-27 20:15 ` Sergei Shtylyov
2019-10-25 20:26 ` [PATCH] mtd: spi-nor: use spi-mem dirmap API Sergei Shtylyov
2019-10-26 7:36 ` Boris Brezillon [this message]
2019-11-07 18:51 ` Sergei Shtylyov
2019-11-07 20:49 ` [PATCH v2] " Sergei Shtylyov
2019-11-07 20:56 ` Sergei Shtylyov
2019-11-07 20:56 ` Sergei Shtylyov
2019-11-09 19:35 ` Boris Brezillon
2019-11-10 19:49 ` Sergei Shtylyov
2020-02-01 20:55 ` [PATCH] mtd: spi-nor: use le32_to_cpu_array() Sergei Shtylyov
2020-02-17 0:03 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191026093602.09a8f0ab@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).