From: kbuild test robot <lkp@intel.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: kbuild-all@lists.01.org, vigneshr@ti.com, richard@nod.at,
yuehaibing@huawei.com, linux-kernel@vger.kernel.org,
frieder.schrempf@kontron.de, linux-mtd@lists.infradead.org,
miquel.raynal@bootlin.com, tglx@linutronix.de,
masonccyang@mxic.com.tw, allison@lohutok.net
Subject: Re: [PATCH -next] mtd: rawnand: macronix: Use match_string() helper to simplify the code
Date: Mon, 30 Dec 2019 20:37:58 +0800 [thread overview]
Message-ID: <201912302029.5N9R0LjB%lkp@intel.com> (raw)
In-Reply-To: <20191230025217.30812-1-yuehaibing@huawei.com>
Hi YueHaibing,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20191220]
[also build test WARNING on linus/master v5.5-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/YueHaibing/mtd-rawnand-macronix-Use-match_string-helper-to-simplify-the-code/20191230-111849
base: 7ddd09fc4b745fb1d8942f95389583e08412e0cd
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
smatch warnings:
drivers/mtd/nand/raw/nand_macronix.c:85 macronix_nand_fix_broken_get_timings() warn: unsigned 'i' is never less than zero.
vim +/i +85 drivers/mtd/nand/raw/nand_macronix.c
54
55 /*
56 * Macronix AC series does not support using SET/GET_FEATURES to change
57 * the timings unlike what is declared in the parameter page. Unflag
58 * this feature to avoid unnecessary downturns.
59 */
60 static void macronix_nand_fix_broken_get_timings(struct nand_chip *chip)
61 {
62 unsigned int i;
63 static const char * const broken_get_timings[] = {
64 "MX30LF1G18AC",
65 "MX30LF1G28AC",
66 "MX30LF2G18AC",
67 "MX30LF2G28AC",
68 "MX30LF4G18AC",
69 "MX30LF4G28AC",
70 "MX60LF8G18AC",
71 "MX30UF1G18AC",
72 "MX30UF1G16AC",
73 "MX30UF2G18AC",
74 "MX30UF2G16AC",
75 "MX30UF4G18AC",
76 "MX30UF4G16AC",
77 "MX30UF4G28AC",
78 };
79
80 if (!chip->parameters.supports_set_get_features)
81 return;
82
83 i = match_string(broken_get_timings, ARRAY_SIZE(broken_get_timings),
84 chip->parameters.model);
> 85 if (i < 0)
86 return;
87
88 bitmap_clear(chip->parameters.get_feature_list,
89 ONFI_FEATURE_ADDR_TIMING_MODE, 1);
90 bitmap_clear(chip->parameters.set_feature_list,
91 ONFI_FEATURE_ADDR_TIMING_MODE, 1);
92 }
93
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-12-30 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 2:52 [PATCH -next] mtd: rawnand: macronix: Use match_string() helper to simplify the code YueHaibing
2019-12-30 12:37 ` kbuild test robot [this message]
2019-12-31 1:36 ` [PATCH v2 " YueHaibing
2020-01-14 17:04 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201912302029.5N9R0LjB%lkp@intel.com \
--to=lkp@intel.com \
--cc=allison@lohutok.net \
--cc=frieder.schrempf@kontron.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=vigneshr@ti.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).