From: Boris Brezillon <boris.brezillon@collabora.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: ron minnich <rminnich@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org,
Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH 1/1] mtd/intel-spi: Support cmdline-based partition
Date: Mon, 27 Apr 2020 11:16:23 +0200 [thread overview]
Message-ID: <20200427111623.5f93842d@collabora.com> (raw)
In-Reply-To: <20200401094148.1786d48a@xps13>
Hi all,
On Wed, 1 Apr 2020 09:41:48 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Hi ron,
>
> ron minnich <rminnich@gmail.com> wrote on Mon, 30 Mar 2020 08:53:22
> -0700:
>
> > On Mon, Mar 30, 2020 at 12:27 AM Miquel Raynal
> > <miquel.raynal@bootlin.com> wrote:
> >
> > > Would it be hard to support an extra ':' after the MTD device name?
> > > This way would would allow anything inside the optional '(' ')' but
> > > would keep the trailing ':'.
> > >
> > > toTay:
> > > mtdparts=name:part1,part2
> > >
> > > So:
> > > mtdparts=(0000:00:1f.5):25165824(BIOS),-(squashfs)
> >
> >
> > I thought about that ':' too. It does add a bit more to the code, and
> > a bit more in the way of error cases. I always worry, when code is
> > going into flash,
> > about errors where something looks close to right but is wrong. (says
> > the person who just typed it instead of is a few times :-)
> >
> > What if we did this:
> > mtdparts=[0000:00:1f.5]25165824(BIOS),-(squashfs)
> >
> > Is the "]" 'enough different' that we do not need the ':'?
> >
> > I kind of like the [] better anyway as it makes the mtdid stand out a
> > bit more from the part names? But is it enough that we don't need the
> > ':'? Would you still prefer the () as opposed to the []?
>
> I like the [] as well, maybe more than () because at least it does not
> conflict with the partition names. But I really prefer keeping the : if
> the code is still readable.
>
> It is much easier to explain to people : "if you have a : in the name,
> enclose it with []".
Sorry to chime in so late in the discussion, but I wonder if any of
that is necessary. Can't we just split the string per device (split
strings every time we see a ';'), and then find the last ':' in each of
those strings and consider everything before that last ':' to be the MTD
name. That should work even if the MTD name contains one or more ':'.
Don't get me wrong, I'm perfectly fine with intel enclosing the PCI
address in [] to make it clearer, but I see that other drivers use ':'
in their MTD device names (the atmel raw NAND controller driver to name
one), so I think it'd be good to make the mtd part parsing robust to
this use case.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-04-27 9:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 19:58 [PATCH 1/1] mtd/intel-spi: Support cmdline-based partition ron minnich
2020-03-23 23:19 ` ron minnich
2020-03-25 17:34 ` ron minnich
2020-03-25 17:34 ` ron minnich
2020-03-27 15:48 ` ron minnich
2020-03-27 15:56 ` Mika Westerberg
2020-03-27 16:19 ` Miquel Raynal
2020-03-27 16:48 ` Mika Westerberg
2020-03-27 16:52 ` Miquel Raynal
2020-03-27 17:05 ` ron minnich
2020-03-27 17:16 ` Mika Westerberg
2020-03-27 17:39 ` ron minnich
2020-03-27 23:53 ` ron minnich
2020-03-30 6:08 ` Mika Westerberg
2020-03-30 7:27 ` Miquel Raynal
2020-03-30 15:53 ` ron minnich
2020-04-01 7:41 ` Miquel Raynal
2020-04-01 15:42 ` ron minnich
2020-04-01 19:49 ` ron minnich
2020-04-27 9:16 ` Boris Brezillon [this message]
2020-04-27 9:49 ` Boris Brezillon
2020-04-27 14:41 ` Miquel Raynal
2020-04-27 18:48 ` ron minnich
2020-04-27 18:50 ` ron minnich
2020-04-27 18:56 ` Miquel Raynal
2020-04-27 18:59 ` ron minnich
2020-04-27 19:21 ` Boris Brezillon
2020-04-27 19:31 ` ron minnich
2020-04-27 20:31 ` ron minnich
2020-04-27 21:20 ` Miquel Raynal
2020-03-27 16:53 ` ron minnich
2020-03-27 16:15 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427111623.5f93842d@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mika.westerberg@linux.intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=rminnich@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).