From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
juliensu@mxic.com.tw, Richard Weinberger <richard@nod.at>,
Boris Brezillon <boris.brezillon@collabora.com>,
linux-mtd@lists.infradead.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
masonccyang@mxic.com.tw
Subject: Re: [PATCH v11 2/2] dt-bindings: mtd: Document boolean NAND ECC properties
Date: Mon, 29 Jun 2020 17:08:00 -0600 [thread overview]
Message-ID: <20200629230800.GA3136006@bogus> (raw)
In-Reply-To: <20200626071357.21421-3-miquel.raynal@bootlin.com>
On Fri, Jun 26, 2020 at 09:13:57AM +0200, Miquel Raynal wrote:
> Document nand-use-soft-ecc-engine and nand-no-ecc-engine properties.
> The former is here to force software correction, the latter prevents
> any correction to happen.
>
> These properties (along with nand-ecc-engine) are supposed to be more
> accurate than the current nand-ecc-modes wich is very misleading and
> very often people think it is mandatory while the core should be
> relied upon to decide which correction to handle.
>
> nand-ecc-mode was already inacurate, but it becomes totally
> problematic with setups where there are several hardware engines.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> Documentation/devicetree/bindings/mtd/nand-controller.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> index 0969d2e6720b..a3750978ebb8 100644
> --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> @@ -68,6 +68,12 @@ patternProperties:
> 3/ The ECC engine is external, in this case the phandle should
> reference the specific ECC engine node.
>
> + nand-use-soft-ecc-engine: true
> + description: Use a software ECC engine.
> +
> + nand-no-ecc-engine: true
> + description: Do not use any ECC correction.
> +
Still the same problem as v10.
You want:
nand-no-ecc-engine:
type: boolean
description: Do not use any ECC correction.
> nand-ecc-placement:
> allOf:
> - $ref: /schemas/types.yaml#/definitions/string
> --
> 2.20.1
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-06-29 23:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 7:13 [PATCH v11 0/2] NAND ECC engine binding changes Miquel Raynal
2020-06-26 7:13 ` [PATCH v11 1/2] dt-bindings: mtd: Document nand-ecc-engine Miquel Raynal
2020-06-29 23:00 ` Rob Herring
2020-06-26 7:13 ` [PATCH v11 2/2] dt-bindings: mtd: Document boolean NAND ECC properties Miquel Raynal
2020-06-29 23:08 ` Rob Herring [this message]
2020-06-30 7:15 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629230800.GA3136006@bogus \
--to=robh@kernel.org \
--cc=Tudor.Ambarus@microchip.com \
--cc=boris.brezillon@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=juliensu@mxic.com.tw \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).