From: Miquel Raynal <miquel.raynal@bootlin.com>
To: sa <saproj@gmail.com>
Cc: Yixun Lan <yixun.lan@amlogic.com>,
Liang Yang <liang.yang@amlogic.com>,
linux-mtd@lists.infradead.org,
Jianxin Pan <jianxin.pan@amlogic.com>
Subject: Re: [PATCH] mtd: meson: fix meson_nfc_dma_buffer_release() arguments
Date: Wed, 28 Oct 2020 09:12:21 +0100 [thread overview]
Message-ID: <20201028091221.4d91241c@xps13> (raw)
In-Reply-To: <20201027222015.17508-1-sa@sas-MacBook-Pro.lan>
Hello Sergei,
sa <saproj@gmail.com> wrote on Wed, 28 Oct 2020 01:20:15 +0300:
> From: Sergei Antonov <saproj@gmail.com>
>
> Arguments 'infolen' and 'datalen' to meson_nfc_dma_buffer_release() were mixed up.
> Also extra spaces removed.
If this is true, then this is definitely a big fix that needs a Fixes:
tag as well as a Cc: stable tag. The other Cc: are not really needed in
the patch though, you just need to add these people when sending the
patch.
Also, please split this into two chunks. Backporting a fix with so much
extra changes is a pain:
- 1/2: fix the arguments
- 2/2: fix the extra spaces (no need for a Fixes/Stable tag here).
Thanks!
Miquèl
> Signed-off-by: Sergei Antonov <saproj@gmail.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Liang Yang <liang.yang@amlogic.com>
> Cc: Yixun Lan <yixun.lan@amlogic.com>
> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-10-28 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 22:20 [PATCH] mtd: meson: fix meson_nfc_dma_buffer_release() arguments sa
2020-10-28 8:12 ` Miquel Raynal [this message]
2020-10-28 9:49 Sergei Antonov
2020-10-28 10:03 ` Miquel Raynal
2020-10-30 2:22 ` Liang Yang
2020-10-30 17:27 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028091221.4d91241c@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=jianxin.pan@amlogic.com \
--cc=liang.yang@amlogic.com \
--cc=linux-mtd@lists.infradead.org \
--cc=saproj@gmail.com \
--cc=yixun.lan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).